Skip to content

Commit 5890aec

Browse files
committed
Fix smoke-windows: skip self-copy for standard variant, fail-fast off
The cp command fails when SUFFIX is empty because source and destination are the same file. Only copy when SUFFIX is non-empty (ui variant). Also add fail-fast: false to smoke-windows so both variants always run.
1 parent 796782e commit 5890aec

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/dry-run.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,7 @@ jobs:
268268
if: ${{ !inputs.skip_builds }}
269269
needs: [build-windows]
270270
strategy:
271+
fail-fast: false
271272
matrix:
272273
variant: [standard, ui]
273274
runs-on: windows-latest
@@ -291,7 +292,7 @@ jobs:
291292
run: |
292293
SUFFIX=${{ matrix.variant == 'ui' && '-ui' || '' }}
293294
unzip -o "codebase-memory-mcp${SUFFIX}-windows-amd64.zip"
294-
cp "codebase-memory-mcp${SUFFIX}.exe" codebase-memory-mcp.exe
295+
[ -n "$SUFFIX" ] && cp "codebase-memory-mcp${SUFFIX}.exe" codebase-memory-mcp.exe || true
295296
296297
- name: Smoke test (${{ matrix.variant }}, windows-amd64)
297298
shell: msys2 {0}

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ jobs:
284284
run: |
285285
SUFFIX=${{ matrix.variant == 'ui' && '-ui' || '' }}
286286
unzip -o "codebase-memory-mcp${SUFFIX}-windows-amd64.zip"
287-
cp "codebase-memory-mcp${SUFFIX}.exe" codebase-memory-mcp.exe
287+
[ -n "$SUFFIX" ] && cp "codebase-memory-mcp${SUFFIX}.exe" codebase-memory-mcp.exe || true
288288
289289
- name: Smoke test (${{ matrix.variant }}, windows-amd64)
290290
shell: msys2 {0}

0 commit comments

Comments
 (0)