From 0187fceb99ff7e4ad9bed26b5ede34f18143e7f9 Mon Sep 17 00:00:00 2001 From: Jino Tesauro Date: Thu, 18 Dec 2025 12:39:26 -0600 Subject: [PATCH 1/3] added relevant test name to close old findings comment --- dojo/importers/default_importer.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dojo/importers/default_importer.py b/dojo/importers/default_importer.py index 3030e7f4e4e..e2af5cebc72 100644 --- a/dojo/importers/default_importer.py +++ b/dojo/importers/default_importer.py @@ -368,8 +368,8 @@ def close_old_findings( self.mitigate_finding( old_finding, ( - "This finding has been automatically closed " - "as it is not present anymore in recent scans." + 'This Finding has been automatically closed by the Test: \n "' + str(self.test) + + '" \n \n This is because the Finding is not present anymore in recent scans.' ), finding_groups_enabled=self.findings_groups_enabled, product_grading_option=False, From 657744e529c2d91c5ffe72b4eeeaf1f016d314fd Mon Sep 17 00:00:00 2001 From: Jino Tesauro Date: Fri, 19 Dec 2025 11:35:27 -0600 Subject: [PATCH 2/3] Added test url to close old finding comment --- dojo/importers/default_importer.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/dojo/importers/default_importer.py b/dojo/importers/default_importer.py index e2af5cebc72..248af23f64a 100644 --- a/dojo/importers/default_importer.py +++ b/dojo/importers/default_importer.py @@ -18,7 +18,7 @@ Test_Import, ) from dojo.notifications.helper import create_notification -from dojo.utils import perform_product_grading +from dojo.utils import get_full_url, perform_product_grading from dojo.validators import clean_tags logger = logging.getLogger(__name__) @@ -365,11 +365,12 @@ def close_old_findings( old_findings = old_findings.filter(Q(service__isnull=True) | Q(service__exact="")) # Update the status of the findings and any endpoints for old_finding in old_findings: + url = get_full_url(reverse("view_test", args=(self.test.id,))) self.mitigate_finding( old_finding, ( - 'This Finding has been automatically closed by the Test: \n "' + str(self.test) + - '" \n \n This is because the Finding is not present anymore in recent scans.' + 'This Finding has been automatically closed by the Test: \n "' + self.test.title + '"\n' + url + + "\n\nThis is because this Finding is not present anymore in recent scans." ), finding_groups_enabled=self.findings_groups_enabled, product_grading_option=False, From e788292ecfb637765ee8a06493db9681160c0138 Mon Sep 17 00:00:00 2001 From: Jino Tesauro Date: Tue, 23 Dec 2025 15:19:43 -0600 Subject: [PATCH 3/3] Better handling for close old findings comments --- dojo/importers/default_importer.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dojo/importers/default_importer.py b/dojo/importers/default_importer.py index 248af23f64a..5a14728043f 100644 --- a/dojo/importers/default_importer.py +++ b/dojo/importers/default_importer.py @@ -365,11 +365,12 @@ def close_old_findings( old_findings = old_findings.filter(Q(service__isnull=True) | Q(service__exact="")) # Update the status of the findings and any endpoints for old_finding in old_findings: - url = get_full_url(reverse("view_test", args=(self.test.id,))) + url = str(get_full_url(reverse("view_test", args=(self.test.id,)))) + test_title = str(self.test.title) self.mitigate_finding( old_finding, ( - 'This Finding has been automatically closed by the Test: \n "' + self.test.title + '"\n' + url + + 'This Finding has been automatically closed by the Test: \n "' + test_title + '"\n' + url + "\n\nThis is because this Finding is not present anymore in recent scans." ), finding_groups_enabled=self.findings_groups_enabled,