Enforce readonly name field for Test_Type instances and add dynamic serializer selection (#14090)

* Enforce readonly name field for existing Test_Type instances in form

* Add TestTypeCreateSerializer and enforce readonly name field in TestTypeSerializer

* Add dynamic serializer selection in TestTypesViewSet for create action

* Update test payload to set 'active' field instead of 'name'

* Update TestTypeTest payload to use 'name' and modify update_fields to 'active'

* Add test to verify 'name' field is read-only in TestType

Author: Maffooch

dojo/api_v2/serializers.py

@@ -1472,8 +1472,15 @@ class Meta:
         exclude = ("inherited_tags",)
 
 
+class TestTypeCreateSerializer(serializers.ModelSerializer):
+
+    class Meta:
+        model = Test_Type
+        exclude = ("dynamically_generated",)
+
+
 class TestTypeSerializer(serializers.ModelSerializer):
-    tags = TagListSerializerField(required=False)
+    name = serializers.ReadOnlyField()
 
     class Meta:
         model = Test_Type

dojo/api_v2/views.py

@@ -2263,6 +2263,11 @@ class TestTypesViewSet(
     def get_queryset(self):
         return Test_Type.objects.all().order_by("id")
 
+    def get_serializer_class(self):
+        if self.action == "create":
+            return serializers.TestTypeCreateSerializer
+        return serializers.TestTypeSerializer
+
 
 # @extend_schema_view(**schema_with_prefetch())
 # Nested models with prefetch make the response schema too long for Swagger UI

dojo/forms.py

@@ -324,6 +324,17 @@ class Meta:
         model = Test_Type
         exclude = ["dynamically_generated"]
 
+    def __init__(self, *args, **kwargs):
+        super().__init__(*args, **kwargs)
+
+        if self.instance.pk:
+            self.fields["name"].widget.attrs["readonly"] = True
+
+    def clean_name(self):
+        if self.instance.pk:
+            return self.instance.name
+        return self.cleaned_data["name"]
+
 
 class Development_EnvironmentForm(forms.ModelForm):
     class Meta:

unittests/test_rest_framework.py

@@ -3452,11 +3452,20 @@ def __init__(self, *args, **kwargs):
         self.payload = {
             "name": "Test_1",
         }
-        self.update_fields = {"name": "Test_2"}
+        self.update_fields = {"active": False}
         self.test_type = TestType.CONFIGURATION_PERMISSIONS
         self.deleted_objects = 1
         BaseClass.RESTEndpointTest.__init__(self, *args, **kwargs)
 
+    def test_name_read_only(self):
+        current_objects = self.client.get(self.url, format="json").data
+        relative_url = self.url + "{}/".format(current_objects["results"][-1]["id"])
+        payload = {"name": "New name"}
+        response = self.client.patch(relative_url, payload, format="json")
+        self.assertEqual(200, response.status_code, response.content[:1000])
+        # See that the request was politley ignored and that name did not change
+        self.assertEqual(current_objects["results"][-1]["name"], response.data["name"])
+
 
 class ConfigurationPermissionTest(BaseClass.BaseClassTest):
     fixtures = ["dojo_testdata.json"]