Skip to content

Commit dc154de

Browse files
Improved naming of discovered findings filter and add same for mitigated (#10429)
* improved naming of findings filter for "on", "before", "after" and added similar for mitigated field on api & UI * fix ruff * fix ruff * Update dojo/filters.py Co-authored-by: Cody Maffucci <46459665+Maffooch@users.noreply.github.com> * Update dojo/filters.py Co-authored-by: Cody Maffucci <46459665+Maffooch@users.noreply.github.com> * Update dojo/filters.py Co-authored-by: Cody Maffucci <46459665+Maffooch@users.noreply.github.com> * fix ruff * fix ruff * Update dojo/filters.py --------- Co-authored-by: Cody Maffucci <46459665+Maffooch@users.noreply.github.com>
1 parent 25a6227 commit dc154de

1 file changed

Lines changed: 16 additions & 7 deletions

File tree

dojo/filters.py

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1420,13 +1420,16 @@ class ApiFindingFilter(DojoFilter):
14201420
# DateRangeFilter
14211421
created = DateRangeFilter()
14221422
date = DateRangeFilter()
1423-
on = DateFilter(field_name="date", lookup_expr="exact")
1424-
before = DateFilter(field_name="date", lookup_expr="lt")
1425-
after = DateFilter(field_name="date", lookup_expr="gt")
1423+
discovered_on = DateFilter(field_name="date", lookup_expr="exact")
1424+
discovered_before = DateFilter(field_name="date", lookup_expr="lt")
1425+
discovered_after = DateFilter(field_name="date", lookup_expr="gt")
14261426
jira_creation = DateRangeFilter(field_name="jira_issue__jira_creation")
14271427
jira_change = DateRangeFilter(field_name="jira_issue__jira_change")
14281428
last_reviewed = DateRangeFilter()
14291429
mitigated = DateRangeFilter()
1430+
mitigated_on = DateFilter(field_name="mitigated", lookup_expr="exact")
1431+
mitigated_before = DateFilter(field_name="mitigated", lookup_expr="lt")
1432+
mitigated_after = DateFilter(field_name="mitigated", lookup_expr="gt")
14301433
# NumberInFilter
14311434
cwe = NumberInFilter(field_name="cwe", lookup_expr="in")
14321435
defect_review_requested_by = NumberInFilter(field_name="defect_review_requested_by", lookup_expr="in")
@@ -1544,17 +1547,20 @@ def filter(self, qs, value):
15441547
class FindingFilterHelper(FilterSet):
15451548
title = CharFilter(lookup_expr="icontains")
15461549
date = DateRangeFilter(field_name="date", label="Date Discovered")
1547-
on = DateFilter(field_name="date", lookup_expr="exact", label="On")
1548-
before = DateFilter(field_name="date", lookup_expr="lt", label="Before")
1549-
after = DateFilter(field_name="date", lookup_expr="gt", label="After")
1550+
on = DateFilter(field_name="date", lookup_expr="exact", label="Discovered On")
1551+
before = DateFilter(field_name="date", lookup_expr="lt", label="Discovered Before")
1552+
after = DateFilter(field_name="date", lookup_expr="gt", label="Discovered After")
15501553
last_reviewed = DateRangeFilter()
15511554
last_status_update = DateRangeFilter()
15521555
cwe = MultipleChoiceFilter(choices=[])
15531556
vulnerability_id = CharFilter(method=vulnerability_id_filter, label="Vulnerability Id")
15541557
severity = MultipleChoiceFilter(choices=SEVERITY_CHOICES)
15551558
duplicate = ReportBooleanFilter()
15561559
is_mitigated = ReportBooleanFilter()
1557-
mitigated = DateRangeFilter(label="Mitigated Date")
1560+
mitigated = DateRangeFilter(field_name="mitigated", label="Mitigated Date")
1561+
mitigated_on = DateFilter(field_name="mitigated", lookup_expr="exact", label="Mitigated On")
1562+
mitigated_before = DateFilter(field_name="mitigated", lookup_expr="lt", label="Mitigated Before")
1563+
mitigated_after = DateFilter(field_name="mitigated", lookup_expr="gt", label="Mitigated After")
15581564
planned_remediation_date = DateRangeOmniFilter()
15591565
planned_remediation_version = CharFilter(lookup_expr="icontains", label=_("Planned remediation version"))
15601566
file_path = CharFilter(lookup_expr="icontains")
@@ -1663,6 +1669,9 @@ def set_date_fields(self, *args: list, **kwargs: dict):
16631669
self.form.fields["on"].widget = date_input_widget
16641670
self.form.fields["before"].widget = date_input_widget
16651671
self.form.fields["after"].widget = date_input_widget
1672+
self.form.fields["mitigated_on"].widget = date_input_widget
1673+
self.form.fields["mitigated_before"].widget = date_input_widget
1674+
self.form.fields["mitigated_after"].widget = date_input_widget
16661675
self.form.fields["cwe"].choices = cwe_options(self.queryset)
16671676

16681677

0 commit comments

Comments
 (0)