fix: improve SLA breach notification format and update overdue/remaining days display (#14746)

Author: Maffooch

dojo/templates/notifications/mail/sla_breach.tpl

@@ -14,14 +14,14 @@
                 {% if sla_age < 0 %}
                   {% blocktranslate trimmed %}
                     This security finding has breached its SLA.
-                    
-                    - Day(s) overdue: {{sla}}
+                    <br/>
+                    - Day(s) overdue: {{sla_age}}
                   {% endblocktranslate %}
                 {% else %}
                   {% blocktranslate trimmed %}
                     A security finding is about to breach its SLA.
-                    
-                    - Day(s) remaining: {{sla}}
+                    <br/>   
+                    - Day(s) remaining: {{sla_age}}
                   {% endblocktranslate %}
                 {% endif %}
             </p>

dojo/utils.py

@@ -1576,12 +1576,13 @@ def _create_notifications():
                     findings_list = []
 
                     for n in comb_notif_kind:
-                        title = _notification_title_for_finding(n.finding, kind, n.finding.sla_days_remaining())
-
+                        sla_age = n.finding.sla_days_remaining()
+                        title = _notification_title_for_finding(n.finding, kind, sla_age)
                         create_notification(
                             event="sla_breach",
                             title=title,
                             finding=n.finding,
+                            sla_age=sla_age,
                             url=reverse("view_finding", args=(n.finding.id,)),
                         )