nightly-dev build

Author: valentijnscholten

.github/workflows/release-2-tag-docker-push.yml

@@ -53,9 +53,17 @@ jobs:
     uses: ./.github/workflows/release-x-manual-merge-container-digests.yml
     with:
       release_number: ${{ github.event.inputs.release_number }}
-      is_latest: 'true'
-      is_latest_boolean: true
-      something: true
+    secrets: inherit
+
+  # for releases we need to tag the images with the latest tag
+  # we tried to parametrize this in the previous workflow after merging the digests,
+  # but for some reason any parameter we add to the workflow will always be empty when referenced
+  # simple enough to just add a explicit workflow for this until we figure out why
+  tag-as-latest:
+    needs: publish-container-digests
+    uses: ./.github/workflows/release-x-manual-tag-as-latest.yml
+    with:
+      release_number: ${{ github.event.inputs.release_number }}
     secrets: inherit
 
   release-helm-chart:

.github/workflows/release-x-manual-merge-container-digests.yml

@@ -13,11 +13,6 @@ on:
             type: string
             description: 'Release version (x.y.z format)'
             required: true
-          is_latest:
-            type: string
-            description: 'Whether to tag releases with latest'
-            required: true
-            default: 'false'
 
     workflow_call:
         inputs:
@@ -27,26 +22,6 @@ on:
             type: string
             description: 'Release version (x.y.z format)'
             required: true
-          is_latest:
-            type: string
-            description: 'Whether to tag releases with latest'
-            required: true
-            default: 'false'
-          is_latest_boolean:
-            type: boolean
-            description: 'Whether to tag releases with latest'
-            required: true
-            default: false
-          something:
-            type: boolean
-            description: 'Whether to tag releases with latest'
-            required: true
-            default: false
-          something_default:
-            type: boolean
-            description: 'Whether to tag releases with latest'
-            required: false
-            default: false
 
 jobs:
   merge-digests:
@@ -58,16 +33,6 @@ jobs:
             os: [alpine, debian]
 
     steps:
-
-    - name: Print inputs
-      run: |
-        echo "Release number: ${{ inputs.release_number }}"
-        echo "Is latest: ${{ inputs.is_latest }}"
-
-    - name: Debug inputs
-      run: |
-        echo "All inputs: ${{ toJson(github.event.inputs) }}"
-
       # deduce docker org name from git repo to make the build also work in forks
     - id: Set-docker-org
       run: echo "DOCKER_ORG=$(echo ${GITHUB_REPOSITORY%%/*} | tr '[:upper:]' '[:lower:]')" >> $GITHUB_ENV
@@ -108,11 +73,6 @@ jobs:
       working-directory: ${{ runner.temp }}/digests
       run: |
         set -x
-        echo release_number: [${{ inputs.release_number }}]
-        echo is_latest: [${{ inputs.is_latest }}]
-        echo is_latest_boolean: [${{ inputs.is_latest_boolean }}]
-        echo something: [${{ inputs.something }}]
-        echo something_default: [${{ inputs.something_default }}]
         docker buildx imagetools create -t "${{ env.DOCKER_ORG }}/defectdojo-${{ matrix.docker-image}}:${{ inputs.release_number }}" ${{ env.DOCKER_ORG }}/defectdojo-${{ matrix.docker-image}}:${{ inputs.release_number }}-${{ matrix.os }}
 
       # debian images are the default / official ones, so these get the latest tag
@@ -123,17 +83,8 @@ jobs:
         set -x
         docker buildx imagetools create -t "${{ env.DOCKER_ORG }}/defectdojo-${{ matrix.docker-image}}:latest" ${{ env.DOCKER_ORG }}/defectdojo-${{ matrix.docker-image}}:${{ inputs.release_number }}-${{ matrix.os }}
 
-      # debian images are the default / official ones, so these get the latest tag
-    - name: Tag Debian with latest tags boolean
-      if: ${{ (matrix.os  == 'debian') && (inputs.is_latest_boolean == 'true' || inputs.is_latest_boolean == true) }}
-      working-directory: ${{ runner.temp }}/digests
-      run: |
-        set -x
-        docker buildx imagetools create -t "${{ env.DOCKER_ORG }}/defectdojo-${{ matrix.docker-image}}:latest" ${{ env.DOCKER_ORG }}/defectdojo-${{ matrix.docker-image}}:${{ inputs.release_number }}-${{ matrix.os }}
-
       # just for logging
     - name: Inspect default images
       if: ${{ matrix.os  == 'debian' }}
       run: |
           docker buildx imagetools inspect ${{ env.DOCKER_ORG }}/defectdojo-${{ matrix.docker-image}}:${{ inputs.release_number }}
-          docker buildx imagetools inspect ${{ env.DOCKER_ORG }}/defectdojo-${{ matrix.docker-image}}:latest

.github/workflows/release-x-nightly-dev.yml

@@ -54,7 +54,6 @@ jobs:
     uses: ./.github/workflows/release-x-manual-merge-container-digests.yml
     with:
         release_number: ${{ github.event.inputs.tag }}
-        is_latest: 'false'
     secrets: inherit
 
   release-helm-chart: