Ruff: Add PLC0415 to dojo/models (#13165)

* Ruff: Add PLC0415 to models

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

Author: manuel-sommer

dojo/models.py

@@ -8,12 +8,14 @@
 from datetime import datetime, timedelta
 from decimal import Decimal
 from pathlib import Path
+from urllib.parse import urlparse
 from uuid import uuid4
 
 import dateutil
 import hyperlink
 import tagulous.admin
 from auditlog.registry import auditlog
+from dateutil.parser import parse as datetutilsparse
 from dateutil.relativedelta import relativedelta
 from django import forms
 from django.conf import settings
@@ -41,6 +43,7 @@
 from polymorphic.models import PolymorphicModel
 from tagulous.models import TagField
 from tagulous.models.managers import FakeTagRelatedManager
+from titlecase import titlecase
 
 from dojo.validators import cvss3_validator, cvss4_validator
 
@@ -670,7 +673,7 @@ class System_Settings(models.Model):
             "This is a performance enhancement to avoid fetching objects unnecessarily.",
         ))
 
-    from dojo.middleware import System_Settings_Manager
+    from dojo.middleware import System_Settings_Manager  # noqa: PLC0415 circular import
     objects = System_Settings_Manager()
 
     def clean(self):
@@ -870,7 +873,6 @@ def __str__(self):
         return self.name
 
     def get_absolute_url(self):
-        from django.urls import reverse
         return reverse("product_type", args=[str(self.id)])
 
     def get_breadcrumbs(self):
@@ -1092,7 +1094,7 @@ def save(self, *args, **kwargs):
                     product.async_updating = True
                     super(Product, product).save()
                 # launch the async task to update all finding sla expiration dates
-                from dojo.sla_config.helpers import update_sla_expiration_dates_sla_config_async
+                from dojo.sla_config.helpers import update_sla_expiration_dates_sla_config_async  # noqa: I001, PLC0415 circular import
                 update_sla_expiration_dates_sla_config_async(self, products, tuple(severities))
 
     def clean(self):
@@ -1254,11 +1256,10 @@ def save(self, *args, **kwargs):
                     sla_config.async_updating = True
                     super(SLA_Configuration, sla_config).save()
                 # launch the async task to update all finding sla expiration dates
-                from dojo.sla_config.helpers import update_sla_expiration_dates_product_async
+                from dojo.sla_config.helpers import update_sla_expiration_dates_product_async  # noqa: I001, PLC0415 circular import
                 update_sla_expiration_dates_product_async(self, sla_config)
 
     def get_absolute_url(self):
-        from django.urls import reverse
         return reverse("view_product", args=[str(self.id)])
 
     @cached_property
@@ -1309,7 +1310,7 @@ def open_findings(self, start_date=None, end_date=None):
         if start_date is None or end_date is None:
             return {}
 
-        from dojo.utils import get_system_setting
+        from dojo.utils import get_system_setting  # noqa: PLC0415 circular import
         findings = Finding.objects.filter(test__engagement__product=self,
                                         mitigated__isnull=True,
                                         false_p=False,
@@ -1347,7 +1348,7 @@ def open_findings_list(self):
 
     @property
     def has_jira_configured(self):
-        import dojo.jira_link.helper as jira_helper
+        import dojo.jira_link.helper as jira_helper  # noqa: PLC0415 circular import
         return jira_helper.has_jira_configured(self)
 
     def violates_sla(self):
@@ -1578,7 +1579,6 @@ def __str__(self):
                                             "%b %d, %Y"))
 
     def get_absolute_url(self):
-        from django.urls import reverse
         return reverse("view_engagement", args=[str(self.id)])
 
     def copy(self):
@@ -1624,7 +1624,7 @@ def get_breadcrumbs(self):
     # only used by bulk risk acceptance api
     @property
     def unaccepted_open_findings(self):
-        from dojo.utils import get_system_setting
+        from dojo.utils import get_system_setting  # noqa: PLC0415 circular import
 
         findings = Finding.objects.filter(risk_accepted=False, active=True, duplicate=False, test__engagement=self)
         if get_system_setting("enforce_verified_status", True) or get_system_setting("enforce_verified_status_metrics", True):
@@ -1637,7 +1637,7 @@ def accept_risks(self, accepted_risks):
 
     @property
     def has_jira_issue(self):
-        import dojo.jira_link.helper as jira_helper
+        import dojo.jira_link.helper as jira_helper  # noqa: PLC0415 circular import
         return jira_helper.has_jira_issue(self)
 
     @property
@@ -1646,8 +1646,8 @@ def is_ci_cd(self):
 
     def delete(self, *args, **kwargs):
         logger.debug("%d engagement delete", self.id)
-        from dojo.finding import helper
-        helper.prepare_duplicates_for_delete(engagement=self)
+        from dojo.finding import helper as finding_helper  # noqa: PLC0415 circular import
+        finding_helper.prepare_duplicates_for_delete(engagement=self)
         super().delete(*args, **kwargs)
         with suppress(Engagement.DoesNotExist, Product.DoesNotExist):
             # Suppressing a potential issue created from async delete removing
@@ -1820,7 +1820,6 @@ def __str__(self):
             return url
 
     def get_absolute_url(self):
-        from django.urls import reverse
         return reverse("view_endpoint", args=[str(self.id)])
 
     def clean(self):
@@ -2038,7 +2037,6 @@ def from_uri(uri):
         try:
             url = hyperlink.parse(url=uri)
         except UnicodeDecodeError:
-            from urllib.parse import urlparse
             url = hyperlink.parse(url="//" + urlparse(uri).netloc)
         except hyperlink.URLParseError as e:
             msg = f"Invalid URL format: {e}"
@@ -2151,7 +2149,6 @@ def __str__(self):
         return str(self.test_type)
 
     def get_absolute_url(self):
-        from django.urls import reverse
         return reverse("view_test", args=[str(self.id)])
 
     def test_type_name(self) -> str:
@@ -2191,7 +2188,7 @@ def copy(self, engagement=None):
     # only used by bulk risk acceptance api
     @property
     def unaccepted_open_findings(self):
-        from dojo.utils import get_system_setting
+        from dojo.utils import get_system_setting  # noqa: PLC0415 circular import
         findings = Finding.objects.filter(risk_accepted=False, active=True, duplicate=False, test=self)
         if get_system_setting("enforce_verified_status", True) or get_system_setting("enforce_verified_status_metrics", True):
             findings = findings.filter(verified=True)
@@ -2740,16 +2737,15 @@ def __str__(self):
     def save(self, dedupe_option=True, rules_option=True, product_grading_option=True,  # noqa: FBT002
              issue_updater_option=True, push_to_jira=False, user=None, *args, **kwargs):  # noqa: FBT002 - this is bit hard to fix nice have this universally fixed
         logger.debug("Start saving finding of id " + str(self.id) + " dedupe_option:" + str(dedupe_option) + " (self.pk is %s)", "None" if self.pk is None else "not None")
-        from dojo.finding import helper as finding_helper
+        from dojo.finding import helper as finding_helper  # noqa: PLC0415 circular import
 
         # if not isinstance(self.date, (datetime, date)):
         #     raise ValidationError(_("The 'date' field must be a valid date or datetime object."))
 
         if not user:
-            from dojo.utils import get_current_user
+            from dojo.utils import get_current_user  # noqa: PLC0415 circular import
             user = get_current_user()
         # Title Casing
-        from titlecase import titlecase
         self.title = titlecase(self.title[:511])
         # Set the date of the finding if nothing is supplied
         if self.date is None:
@@ -2788,7 +2784,7 @@ def save(self, dedupe_option=True, rules_option=True, product_grading_option=Tru
 
         if self.pk is None:
             # We enter here during the first call from serializers.py
-            from dojo.utils import apply_cwe_to_template
+            from dojo.utils import apply_cwe_to_template  # noqa: PLC0415 circular import
             # No need to use the returned variable since `self` Is updated in memory
             apply_cwe_to_template(self)
             if (self.file_path is not None) and (len(self.unsaved_endpoints) == 0):
@@ -2826,7 +2822,6 @@ def save(self, dedupe_option=True, rules_option=True, product_grading_option=Tru
             logger.debug("no options selected that require finding post processing")
 
     def get_absolute_url(self):
-        from django.urls import reverse
         return reverse("view_finding", args=[str(self.id)])
 
     def copy(self, test=None):
@@ -2863,8 +2858,8 @@ def copy(self, test=None):
 
     def delete(self, *args, **kwargs):
         logger.debug("%d finding delete", self.id)
-        from dojo.finding import helper
-        helper.finding_delete(self)
+        from dojo.finding import helper as finding_helper  # noqa: PLC0415 circular import
+        finding_helper.finding_delete(self)
         super().delete(*args, **kwargs)
         with suppress(Finding.DoesNotExist, Test.DoesNotExist, Engagement.DoesNotExist, Product.DoesNotExist):
             # Suppressing a potential issue created from async delete removing
@@ -2874,7 +2869,7 @@ def delete(self, *args, **kwargs):
     # only used by bulk risk acceptance api
     @classmethod
     def unaccepted_open_findings(cls):
-        from dojo.utils import get_system_setting
+        from dojo.utils import get_system_setting  # noqa: PLC0415 circular import
         results = cls.objects.filter(active=True, duplicate=False, risk_accepted=False)
         if get_system_setting("enforce_verified_status", True) or get_system_setting("enforce_verified_status_metrics", True):
             results = results.filter(verified=True)
@@ -3084,9 +3079,8 @@ def status(self):
         return ", ".join([str(s) for s in status])
 
     def _age(self, start_date):
-        from dateutil.parser import parse
         if start_date and isinstance(start_date, str):
-            start_date = parse(start_date).date()
+            start_date = datetutilsparse(start_date).date()
 
         if isinstance(start_date, datetime):
             start_date = start_date.date()
@@ -3183,7 +3177,7 @@ def github_conf_new(self):
 
     @property
     def has_jira_issue(self):
-        import dojo.jira_link.helper as jira_helper
+        import dojo.jira_link.helper as jira_helper  # noqa: PLC0415 circular import
         return jira_helper.has_jira_issue(self)
 
     @cached_property
@@ -3196,12 +3190,12 @@ def has_jira_group_issue(self):
         if not self.has_finding_group:
             return False
 
-        import dojo.jira_link.helper as jira_helper
+        import dojo.jira_link.helper as jira_helper  # noqa: PLC0415 circular import
         return jira_helper.has_jira_issue(self.finding_group)
 
     @property
     def has_jira_configured(self):
-        import dojo.jira_link.helper as jira_helper
+        import dojo.jira_link.helper as jira_helper  # noqa: PLC0415 circular import
         return jira_helper.has_jira_configured(self)
 
     @cached_property
@@ -3281,7 +3275,7 @@ def latest_note(self):
         return ""
 
     def get_sast_source_file_path_with_link(self):
-        from dojo.utils import create_bleached_link
+        from dojo.utils import create_bleached_link  # noqa: PLC0415 circular import
         if self.sast_source_file_path is None:
             return None
         if self.test.engagement.source_code_management_uri is None:
@@ -3292,7 +3286,7 @@ def get_sast_source_file_path_with_link(self):
         return create_bleached_link(link, self.sast_source_file_path)
 
     def get_file_path_with_link(self):
-        from dojo.utils import create_bleached_link
+        from dojo.utils import create_bleached_link  # noqa: PLC0415 circular import
         if self.file_path is None:
             return None
         if self.test.engagement.source_code_management_uri is None:
@@ -3406,9 +3400,7 @@ def get_file_path_with_raw_link(self):
         return link
 
     def get_references_with_links(self):
-        import re
-
-        from dojo.utils import create_bleached_link
+        from dojo.utils import create_bleached_link  # noqa: PLC0415 circular import
         if self.references is None:
             return None
         matches = re.findall(r"([\(|\[]?(https?):((//)|(\\\\))+([\w\d:#@%/;$~_?\+-=\\\.&](#!)?)*[\)|\]]?)", self.references)
@@ -3452,7 +3444,7 @@ def violates_sla(self):
         return (self.sla_expiration_date and self.sla_expiration_date < timezone.now().date())
 
     def set_hash_code(self, dedupe_option):
-        from dojo.utils import get_custom_method
+        from dojo.utils import get_custom_method  # noqa: PLC0415 circular import
         if hash_method := get_custom_method("FINDING_HASH_METHOD"):
             hash_method(self, dedupe_option)
         # Finding.save is called once from serializers.py with dedupe_option=False because the finding is not ready yet, for example the endpoints are not built
@@ -3481,7 +3473,6 @@ def __str__(self):
         return self.vulnerability_id
 
     def get_absolute_url(self):
-        from django.urls import reverse
         return reverse("view_finding", args=[str(self.finding.id)])
 
 
@@ -3524,7 +3515,7 @@ def __str__(self):
 
     @property
     def has_jira_issue(self):
-        import dojo.jira_link.helper as jira_helper
+        import dojo.jira_link.helper as jira_helper  # noqa: PLC0415 circular import
         return jira_helper.has_jira_issue(self)
 
     @cached_property
@@ -3585,7 +3576,6 @@ def get_sla_start_date(self):
         return min(find.get_sla_start_date() for find in self.findings.all())
 
     def get_absolute_url(self):
-        from django.urls import reverse
         return reverse("view_test", args=[str(self.test.id)])
 
     class Meta:
@@ -3624,7 +3614,6 @@ def __str__(self):
         return self.title
 
     def get_absolute_url(self):
-        from django.urls import reverse
         return reverse("edit_template", args=[str(self.id)])
 
     def get_breadcrumbs(self):
@@ -4567,7 +4556,7 @@ class TextQuestion(Question):
 
     def get_form(self):
         """Returns the form for this model"""
-        from .forms import TextQuestionForm
+        from .forms import TextQuestionForm  # noqa: PLC0415
         return TextQuestionForm
 
 
@@ -4600,7 +4589,7 @@ class ChoiceQuestion(Question):
 
     def get_form(self):
         """Returns the form for this model"""
-        from .forms import ChoiceQuestionForm
+        from .forms import ChoiceQuestionForm  # noqa: PLC0415
         return ChoiceQuestionForm
 
 

ruff.toml

@@ -114,9 +114,9 @@ preview = true
     "S105",  # hardcoded passwords in tests are fine
     "S108",  # tmp paths mentioned in tests are fine
 ]
+
 "dojo/models.py" = [
     "PLC1901",  # fix later, causes some problems
-    "PLC0415",  # fix later
 ]
 
 [lint.flake8-boolean-trap]