fix(api): Enable to set recommendation and decision in risk_acceptance (#12303)

Author: kiblik

dojo/api_v2/serializers.py

@@ -1525,8 +1525,6 @@ class Meta:
 
 
 class RiskAcceptanceSerializer(serializers.ModelSerializer):
-    recommendation = serializers.SerializerMethodField()
-    decision = serializers.SerializerMethodField()
     path = serializers.SerializerMethodField()
 
     def create(self, validated_data):
@@ -1554,14 +1552,6 @@ def update(self, instance, validated_data):
             ra_helper.remove_finding_from_risk_acceptance(user, instance, finding)
         return instance
 
-    @extend_schema_field(serializers.CharField())
-    def get_recommendation(self, obj):
-        return Risk_Acceptance.TREATMENT_TRANSLATIONS.get(obj.recommendation)
-
-    @extend_schema_field(serializers.CharField())
-    def get_decision(self, obj):
-        return Risk_Acceptance.TREATMENT_TRANSLATIONS.get(obj.decision)
-
     @extend_schema_field(serializers.CharField())
     def get_path(self, obj):
         engagement = Engagement.objects.filter(

unittests/test_rest_framework.py

@@ -1009,8 +1009,8 @@ def __init__(self, *args, **kwargs):
         self.viewset = RiskAcceptanceViewSet
         self.payload = {
             "id": 2,
-            "recommendation": "Fix (The risk is eradicated)",
-            "decision": "Accept (The risk is acknowledged, yet remains)",
+            "recommendation": "F",
+            "decision": "A",
             "path": "No proof has been supplied",
             "name": "string",
             "recommendation_details": "string",
@@ -1046,8 +1046,8 @@ def test_create_object_not_authorized(self):
     def test_update_forbidden_engagement(self):
         self.payload = {
             "id": 1,
-            "recommendation": "Fix (The risk is eradicated)",
-            "decision": "Accept (The risk is acknowledged, yet remains)",
+            "recommendation": "F",
+            "decision": "A",
             "path": "No proof has been supplied",
             "name": "string",
             "recommendation_details": "string",