Ruff: Final fix of PTH123 (#12177)

Author: kiblik

ruff.toml

@@ -114,9 +114,6 @@ preview = true
     "S105",  # hardcoded passwords in tests are fine
     "S108",  # tmp paths mentioned in tests are fine
 ]
-"unittests/tools/**" = [
-    "PTH123", # Fix is needed in unittests/tools as well but there are too many problematic files, let's do it per partes
-]
 ".github/pr-reminder.py" = [
     "INP001", # https://docs.astral.sh/ruff/rules/implicit-namespace-package/
 ]

unittests/tools/test_acunetix_parser.py

@@ -9,7 +9,7 @@
 class TestAcunetixParser(DojoTestCase):
 
     def test_parse_file_with_one_finding(self):
-        with open(get_unit_tests_scans_path("acunetix") / "one_finding.xml", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("acunetix") / "one_finding.xml").open(encoding="utf-8") as testfile:
             parser = AcunetixParser()
             findings = parser.get_findings(testfile, Test())
             for finding in findings:
@@ -37,7 +37,7 @@ def test_parse_file_with_one_finding(self):
                 self.assertEqual("some/path", endpoint.path)
 
     def test_parse_file_with_multiple_finding(self):
-        with open(get_unit_tests_scans_path("acunetix") / "many_findings.xml", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("acunetix") / "many_findings.xml").open(encoding="utf-8") as testfile:
             parser = AcunetixParser()
             findings = parser.get_findings(testfile, Test())
             for finding in findings:
@@ -132,7 +132,7 @@ def test_parse_file_with_multiple_finding(self):
                 self.assertIsInstance(req_resp["resp"], str)
 
     def test_parse_file_with_example_com(self):
-        with open(get_unit_tests_scans_path("acunetix") / "XML_http_example_co_id_.xml", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("acunetix") / "XML_http_example_co_id_.xml").open(encoding="utf-8") as testfile:
             parser = AcunetixParser()
             findings = parser.get_findings(testfile, Test())
             for finding in findings:
@@ -204,7 +204,7 @@ def test_parse_file_with_example_com(self):
                 self.assertIsInstance(req_resp["resp"], str)
 
     def test_parse_file_with_one_finding_acunetix360(self):
-        with open(get_unit_tests_scans_path("acunetix") / "acunetix360_one_finding.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("acunetix") / "acunetix360_one_finding.json").open(encoding="utf-8") as testfile:
             parser = AcunetixParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(1, len(findings))
@@ -225,7 +225,7 @@ def test_parse_file_with_one_finding_acunetix360(self):
                 self.assertIn("https://online.acunetix360.com/issues/detail/735f4503-e9eb-4b4c-4306-ad49020a4c4b", finding.references)
 
     def test_parse_file_with_one_finding_false_positive(self):
-        with open(get_unit_tests_scans_path("acunetix") / "acunetix360_one_finding_false_positive.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("acunetix") / "acunetix360_one_finding_false_positive.json").open(encoding="utf-8") as testfile:
             parser = AcunetixParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(1, len(findings))
@@ -245,7 +245,7 @@ def test_parse_file_with_one_finding_false_positive(self):
                 self.assertTrue(finding.false_p)
 
     def test_parse_file_with_one_finding_risk_accepted(self):
-        with open(get_unit_tests_scans_path("acunetix") / "acunetix360_one_finding_accepted_risk.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("acunetix") / "acunetix360_one_finding_accepted_risk.json").open(encoding="utf-8") as testfile:
             parser = AcunetixParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(1, len(findings))
@@ -265,7 +265,7 @@ def test_parse_file_with_one_finding_risk_accepted(self):
                 self.assertTrue(finding.risk_accepted)
 
     def test_parse_file_with_multiple_finding_acunetix360(self):
-        with open(get_unit_tests_scans_path("acunetix") / "acunetix360_many_findings.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("acunetix") / "acunetix360_many_findings.json").open(encoding="utf-8") as testfile:
             parser = AcunetixParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(16, len(findings))
@@ -306,7 +306,7 @@ def test_parse_file_with_multiple_finding_acunetix360(self):
                 self.assertEqual(str(endpoint), "http://php.testsparker.com")
 
     def test_parse_file_with_mulitple_cwe(self):
-        with open(get_unit_tests_scans_path("acunetix") / "acunetix360_multiple_cwe.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("acunetix") / "acunetix360_multiple_cwe.json").open(encoding="utf-8") as testfile:
             parser = AcunetixParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(1, len(findings))
@@ -325,19 +325,19 @@ def test_parse_file_with_mulitple_cwe(self):
                 self.assertEqual(str(endpoint), "http://php.testsparker.com/auth/login.php")
 
     def test_parse_file_issue_10370(self):
-        with open(get_unit_tests_scans_path("acunetix") / "issue_10370.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("acunetix") / "issue_10370.json").open(encoding="utf-8") as testfile:
             parser = AcunetixParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(1, len(findings))
 
     def test_parse_file_issue_10435(self):
-        with open(get_unit_tests_scans_path("acunetix") / "issue_10435.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("acunetix") / "issue_10435.json").open(encoding="utf-8") as testfile:
             parser = AcunetixParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(1, len(findings))
 
     def test_parse_file_issue_11206(self):
-        with open(get_unit_tests_scans_path("acunetix") / "issue_11206.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("acunetix") / "issue_11206.json").open(encoding="utf-8") as testfile:
             parser = AcunetixParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(1, len(findings))

unittests/tools/test_anchore_engine_parser.py

@@ -5,25 +5,25 @@
 
 class TestAnchoreEngineParser(DojoTestCase):
     def test_anchore_engine_parser_has_no_finding(self):
-        with open(get_unit_tests_scans_path("anchore_engine") / "no_vuln.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchore_engine") / "no_vuln.json").open(encoding="utf-8") as testfile:
             parser = AnchoreEngineParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(0, len(findings))
 
     def test_anchore_engine_parser_has_one_finding(self):
-        with open(get_unit_tests_scans_path("anchore_engine") / "one_vuln.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchore_engine") / "one_vuln.json").open(encoding="utf-8") as testfile:
             parser = AnchoreEngineParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(1, len(findings))
 
     def test_anchore_engine_parser_has_many_findings(self):
-        with open(get_unit_tests_scans_path("anchore_engine") / "many_vulns.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchore_engine") / "many_vulns.json").open(encoding="utf-8") as testfile:
             parser = AnchoreEngineParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(23, len(findings))
 
     def test_anchore_engine_parser_has_many_findings_2_4_1(self):
-        with open(get_unit_tests_scans_path("anchore_engine") / "many_vulns_2.4.1.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchore_engine") / "many_vulns_2.4.1.json").open(encoding="utf-8") as testfile:
             parser = AnchoreEngineParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(51, len(findings))
@@ -36,7 +36,7 @@ def test_anchore_engine_parser_has_many_findings_2_4_1(self):
             self.assertEqual("CVE-2020-13776", finding.unsaved_vulnerability_ids[0])
 
     def test_anchore_engine_parser_new_fomrat_issue_11552(self):
-        with open(get_unit_tests_scans_path("anchore_engine") / "new_format_issue_11552.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchore_engine") / "new_format_issue_11552.json").open(encoding="utf-8") as testfile:
             parser = AnchoreEngineParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(84, len(findings))

unittests/tools/test_anchore_enterprise_parser.py

@@ -6,19 +6,19 @@
 
 class TestAnchoreEnterpriseParser(DojoTestCase):
     def test_anchore_policy_check_parser_has_no_findings(self):
-        with open(get_unit_tests_scans_path("anchore_enterprise") / "no_checks.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchore_enterprise") / "no_checks.json").open(encoding="utf-8") as testfile:
             parser = AnchoreEnterpriseParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(0, len(findings))
 
     def test_anchore_policy_check_parser_has_one_finding(self):
-        with open(get_unit_tests_scans_path("anchore_enterprise") / "one_check.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchore_enterprise") / "one_check.json").open(encoding="utf-8") as testfile:
             parser = AnchoreEnterpriseParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(1, len(findings))
 
     def test_anchore_policy_check_parser_has_multiple_findings(self):
-        with open(get_unit_tests_scans_path("anchore_enterprise") / "many_checks.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchore_enterprise") / "many_checks.json").open(encoding="utf-8") as testfile:
             parser = AnchoreEnterpriseParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(57, len(findings))
@@ -27,7 +27,7 @@ def test_anchore_policy_check_parser_has_multiple_findings(self):
             self.assertEqual("CVE-2015-2992", finding.unsaved_vulnerability_ids[0])
 
     def test_anchore_policy_check_parser_invalid_format(self):
-        with open(get_unit_tests_scans_path("anchore_enterprise") / "invalid_checks_format.json", encoding="utf-8") as testfile, \
+        with (get_unit_tests_scans_path("anchore_enterprise") / "invalid_checks_format.json").open(encoding="utf-8") as testfile, \
            self.assertRaises(ValueError):
             parser = AnchoreEnterpriseParser()
             parser.get_findings(testfile, Test())

unittests/tools/test_anchore_grype_parser.py

@@ -6,14 +6,14 @@
 class TestAnchoreGrypeParser(DojoTestCase):
 
     def test_parser_has_no_findings(self):
-        with open(get_unit_tests_scans_path("anchore_grype") / "no_vuln.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchore_grype") / "no_vuln.json").open(encoding="utf-8") as testfile:
             parser = AnchoreGrypeParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(0, len(findings))
 
     def test_parser_has_many_findings(self):
         found = False
-        with open(get_unit_tests_scans_path("anchore_grype") / "many_vulns.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchore_grype") / "many_vulns.json").open(encoding="utf-8") as testfile:
             parser = AnchoreGrypeParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(1509, len(findings))
@@ -35,7 +35,7 @@ def test_parser_has_many_findings(self):
 
     def test_grype_parser_with_one_criticle_vuln_has_one_findings(self):
         found = False
-        with open(get_unit_tests_scans_path("anchore_grype") / "many_vulns2.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchore_grype") / "many_vulns2.json").open(encoding="utf-8") as testfile:
             parser = AnchoreGrypeParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(1567, len(findings))
@@ -56,7 +56,7 @@ def test_grype_parser_with_one_criticle_vuln_has_one_findings(self):
 
     def test_grype_parser_with_many_vulns3(self):
         found = False
-        with open(get_unit_tests_scans_path("anchore_grype") / "many_vulns3.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchore_grype") / "many_vulns3.json").open(encoding="utf-8") as testfile:
             parser = AnchoreGrypeParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(327, len(findings))
@@ -77,7 +77,7 @@ def test_grype_parser_with_many_vulns3(self):
 
     def test_grype_parser_with_new_matcher_list(self):
         found = False
-        with open(get_unit_tests_scans_path("anchore_grype") / "many_vulns4.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchore_grype") / "many_vulns4.json").open(encoding="utf-8") as testfile:
             parser = AnchoreGrypeParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(9, len(findings))
@@ -97,7 +97,7 @@ def test_grype_parser_with_new_matcher_list(self):
             self.assertTrue(found)
 
     def test_check_all_fields(self):
-        with open(get_unit_tests_scans_path("anchore_grype") / "check_all_fields.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchore_grype") / "check_all_fields.json").open(encoding="utf-8") as testfile:
             parser = AnchoreGrypeParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(5, len(findings))
@@ -266,13 +266,13 @@ def test_check_all_fields(self):
             self.assertEqual(2, finding.nb_occurences)
 
     def test_grype_issue_9618(self):
-        with open(get_unit_tests_scans_path("anchore_grype") / "issue_9618.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchore_grype") / "issue_9618.json").open(encoding="utf-8") as testfile:
             parser = AnchoreGrypeParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(35, len(findings))
 
     def test_grype_issue_9942(self):
-        with open(get_unit_tests_scans_path("anchore_grype") / "issue_9942.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchore_grype") / "issue_9942.json").open(encoding="utf-8") as testfile:
             parser = AnchoreGrypeParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(1, len(findings))

unittests/tools/test_anchorectl_policies_parser.py

@@ -5,13 +5,13 @@
 
 class TestAnchoreCTLPoliciesParser(DojoTestCase):
     def test_anchore_engine_parser_has_no_finding(self):
-        with open(get_unit_tests_scans_path("anchorectl_policies") / "no_violation.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchorectl_policies") / "no_violation.json").open(encoding="utf-8") as testfile:
             parser = AnchoreCTLPoliciesParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(0, len(findings))
 
     def test_anchore_engine_parser_has_one_finding_and_it_is_correctly_parsed(self):
-        with open(get_unit_tests_scans_path("anchorectl_policies") / "one_violation.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchorectl_policies") / "one_violation.json").open(encoding="utf-8") as testfile:
             parser = AnchoreCTLPoliciesParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(1, len(findings))
@@ -21,13 +21,13 @@ def test_anchore_engine_parser_has_one_finding_and_it_is_correctly_parsed(self):
             self.assertEqual(singleFinding.description, "User root found as effective user, which is not on the allowed list")
 
     def test_anchore_engine_parser_has_many_findings(self):
-        with open(get_unit_tests_scans_path("anchorectl_policies") / "many_violations.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchorectl_policies") / "many_violations.json").open(encoding="utf-8") as testfile:
             parser = AnchoreCTLPoliciesParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(3, len(findings))
 
     def test_anchore_engine_parser_has_one_finding_and_description_has_severity(self):
-        with open(get_unit_tests_scans_path("anchorectl_policies") / "one_violation_description_severity.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchorectl_policies") / "one_violation_description_severity.json").open(encoding="utf-8") as testfile:
             parser = AnchoreCTLPoliciesParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(1, len(findings))

unittests/tools/test_anchorectl_vulns_parser.py

@@ -5,13 +5,13 @@
 
 class TestAnchoreCTLVulnsParser(DojoTestCase):
     def test_anchore_engine_parser_has_no_finding(self):
-        with open(get_unit_tests_scans_path("anchorectl_vulns") / "no_vuln.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchorectl_vulns") / "no_vuln.json").open(encoding="utf-8") as testfile:
             parser = AnchoreCTLVulnsParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(0, len(findings))
 
     def test_anchore_engine_parser_has_one_finding_and_it_is_correctly_parsed(self):
-        with open(get_unit_tests_scans_path("anchorectl_vulns") / "one_vuln.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchorectl_vulns") / "one_vuln.json").open(encoding="utf-8") as testfile:
             parser = AnchoreCTLVulnsParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(1, len(findings))
@@ -21,7 +21,7 @@ def test_anchore_engine_parser_has_one_finding_and_it_is_correctly_parsed(self):
             self.assertEqual(singleFinding.description, "**Image hash**: None\n\n**Package**: libgnutls30-3.5.8-5+deb9u4\n\n**Package path**: None\n\n**Package type**: dpkg\n\n**Feed**: vulnerabilities/debian:9\n\n**CPE**: None\n\n**Description**: That test description\n\n")
 
     def test_anchore_engine_parser_has_many_findings(self):
-        with open(get_unit_tests_scans_path("anchorectl_vulns") / "many_vulns.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("anchorectl_vulns") / "many_vulns.json").open(encoding="utf-8") as testfile:
             parser = AnchoreCTLVulnsParser()
             findings = parser.get_findings(testfile, Test())
             self.assertEqual(23, len(findings))

unittests/tools/test_api_blackduck_parser.py

@@ -7,7 +7,7 @@
 class TestApiBlackduckParser(DojoTestCase):
 
     def test_bandit_parser_has_many_findings(self):
-        with open(get_unit_tests_scans_path("api_blackduck") / "many_vulns.json", encoding="utf-8") as testfile:
+        with (get_unit_tests_scans_path("api_blackduck") / "many_vulns.json").open(encoding="utf-8") as testfile:
             parser = ApiBlackduckParser()
             findings = parser.get_findings(testfile, Test())
             for finding in findings: