feat(unittest): Small improvements in unittests (#13064)

Author: kiblik

unittests/test_parsers.py

@@ -96,7 +96,7 @@ def test_file_existence(self):
                                     read_true = False
                                     i = 0
                                 elif i > 4:
-                                    self.assertTrue(expr=False, msg=f"In file '{f_path}' the test is failing because you don't have utf-8 after .read()")
+                                    self.fail(f"In file '{f_path}' the test is failing because you don't have utf-8 after .read()")
                                     i = 0
                                     read_true = False
                                 else:

unittests/test_sla_calculations.py

@@ -95,8 +95,8 @@ def test_mitigated_inside_sla(self):
             self.assertEqual(initial_sla_expiration_date, finding.sla_expiration_date)
             self.assertEqual((self.now + relativedelta(days=self.sla_config.high)).date(), finding.sla_expiration_date)
             self.assertEqual(20, finding.sla_days_remaining())
-            self.assertTrue("within SLA" in finding_sla(finding))
-            self.assertTrue(">20<" in finding_sla(finding))
+            self.assertIn("within SLA", finding_sla(finding))
+            self.assertIn(">20<", finding_sla(finding))
 
         with patch("django.db.models.fields.timezone.now") as mock_now:
             mock_now.return_value = self.now + relativedelta(days=20)
@@ -109,8 +109,8 @@ def test_mitigated_inside_sla(self):
             self.assertEqual(initial_sla_expiration_date, finding.sla_expiration_date)
             self.assertEqual((self.now + relativedelta(days=self.sla_config.high)).date(), finding.sla_expiration_date)
             self.assertEqual(20, finding.sla_days_remaining())
-            self.assertTrue("within SLA" in finding_sla(finding))
-            self.assertTrue(">20<" in finding_sla(finding))
+            self.assertIn("within SLA", finding_sla(finding))
+            self.assertIn(">20<", finding_sla(finding))
 
     # Finding mitigated outside SLA should have correct sla_expiration_date and days_remaining
     def test_mitigated_outside_sla(self):

unittests/tools/test_twistlock_parser.py

@@ -41,7 +41,7 @@ def test_parse_file_with_one_vuln_and_compliance(self):
                 # Verify compliance finding has image metadata in impact field
                 self.assertIn("Image ID:", finding.impact)
                 self.assertIn("Distribution:", finding.impact)
-                self.assertTrue("\n" in finding.impact)
+                self.assertIn("\n", finding.impact)
             else:
                 # Verify vulnerability finding exists and has correct properties
                 self.assertIsNotNone(finding)
@@ -52,7 +52,7 @@ def test_parse_file_with_one_vuln_and_compliance(self):
                 self.assertIn("Image ID:", finding.impact)
                 self.assertIn("Distribution:", finding.impact)
                 self.assertIn("Debian GNU/Linux 9", finding.impact)
-                self.assertTrue("\n" in finding.impact)
+                self.assertIn("\n", finding.impact)
 
     def test_parse_csv_with_timestamps_and_metadata(self):
         testfile = (
@@ -69,8 +69,8 @@ def test_parse_csv_with_timestamps_and_metadata(self):
         # Verify timestamp parsing (Item 4)
         self.assertIsNotNone(finding.date)
         # Should use Published date (2020-09-04) or Discovered date (2020-09-29)
-        self.assertTrue(finding.date.year == 2020)
-        self.assertTrue(finding.date.month in {9, 1, 11, 12})  # Various months from the test data
+        self.assertEqual(finding.date.year, 2020)
+        self.assertIn(finding.date.month, {9, 1, 11, 12})  # Various months from the test data
 
         # Verify metadata in impact field (Item 3) - now separated by newlines
         self.assertIn("Registry:", finding.impact)