Ruff: Add and fix B007, merge B00 (#12028)

Author: kiblik

dojo/api_v2/prefetch/schema.py

@@ -6,7 +6,7 @@ def _get_path_to_GET_serializer_map(generator):
     path_to_GET_serializer = {}
     for (
         path,
-        path_pattern,
+        _path_pattern,
         method,
         view,
     ) in generator._get_paths_and_endpoints():

dojo/forms.py

@@ -2422,7 +2422,7 @@ class Meta:
 def get_jira_issue_template_dir_choices():
     template_root = settings.JIRA_TEMPLATE_ROOT
     template_dir_list = [("", "---")]
-    for base_dir, dirnames, filenames in os.walk(template_root):
+    for base_dir, dirnames, _filenames in os.walk(template_root):
         # for filename in filenames:
         #     if base_dir.startswith(settings.TEMPLATE_DIR_PREFIX):
         #         base_dir = base_dir[len(settings.TEMPLATE_DIR_PREFIX):]

dojo/templatetags/event_tags.py

@@ -69,7 +69,7 @@ def is_text(field):
 @register.filter
 def sum_dict(d):
     total = 0
-    for key, value in list(d.items()):
+    for value in d.values():
         total += value
     return total
 

dojo/tools/legitify/parser.py

@@ -39,7 +39,7 @@ def get_findings(self, file, test):
         report_tree = self.parse_json(file)
 
         findings = []
-        for content_key, content_value in report_tree.get("content", {}).items():
+        for content_value in report_tree.get("content", {}).values():
             policy_info = content_value.get("policyInfo", {})
             is_finding = False
             endpoints = set()

dojo/tools/mobsf/parser.py

@@ -215,7 +215,7 @@ def get_findings(self, filename, test):
                             }
                             mobsf_findings.append(mobsf_item)
             elif data["binary_analysis"].get("findings"):
-                for binary_analysis_type, details in list(data["binary_analysis"]["findings"].items()):
+                for details in data["binary_analysis"]["findings"].values():
                     # "findings":{
                     #     "Binary makes use of insecure API(s)":{
                     #         "detailed_desc":"The binary may contain the following insecure API(s) _memcpy\n, _strlen\n",
@@ -234,7 +234,7 @@ def get_findings(self, filename, test):
                     }
                     mobsf_findings.append(mobsf_item)
             else:
-                for binary_analysis_type, details in list(data["binary_analysis"].items()):
+                for details in data["binary_analysis"].values():
                     # "Binary makes use of insecure API(s)":{
                     #     "detailed_desc":"The binary may contain the following insecure API(s) _vsprintf.",
                     #     "severity":"high",

dojo/tools/npm_audit/parser.py

@@ -51,7 +51,7 @@ def parse_json(self, json_output):
     def get_items(self, tree, test):
         items = {}
 
-        for key, node in tree.items():
+        for node in tree.values():
             item = get_item(node, test)
             unique_key = str(node["id"]) + str(node["module_name"])
             items[unique_key] = item

dojo/tools/npm_audit_7_plus/parser.py

@@ -83,7 +83,7 @@ def get_items(self, tree, test):
         """Return the individual items found in report."""
         items = {}
 
-        for key, node in tree.items():
+        for node in tree.values():
             item = get_item(node, tree, test)
             unique_key = item.title + item.severity
             items[unique_key] = item

dojo/utils.py

@@ -2213,7 +2213,7 @@ def add_error_message_to_response(message):
 
 def add_field_errors_to_response(form):
     if form and get_current_request():
-        for field, error in form.errors.items():
+        for error in form.errors.values():
             add_error_message_to_response(error)
 
 
@@ -2251,7 +2251,7 @@ def mass_model_updater(model_type, models, function, fields, page_size=1000, ord
     total_pages = (total_count // page_size) + 2
     # logger.info('pages to process: %d', total_pages)
     logger.debug("%s%s out of %s models processed ...", log_prefix, i, total_count)
-    for p in range(1, total_pages):
+    for _p in range(1, total_pages):
         # logger.info('page: %d', p)
         if order == "asc":
             page = models.filter(id__gt=last_id)[:page_size]

ruff.toml

@@ -85,8 +85,7 @@ select = [
    "FURB",
    "DOC202", "DOC403", "DOC502",
    "RUF",
-   "B006",
-   "B009",
+   "B00",
    "B010",
    "B033",
    "B903",

tests/close_old_findings_dedupe_test.py

@@ -28,7 +28,7 @@ def setUp(self):
     def check_nb_duplicates(self, expected_number_of_duplicates):
         logger.debug("checking duplicates...")
         driver = self.driver
-        for i in range(18):
+        for _ in range(18):
             time.sleep(5)  # wait bit for celery dedupe task which can be slow on travis
             self.goto_all_findings_list(driver)
             dupe_count = 0