Parsers: Specify lists rather than dict.values() (#10945)

Author: Maffooch

dojo/tools/blackduck/parser.py

@@ -78,7 +78,7 @@ def ingest_findings(self, normalized_findings, test):
 
                 dupes[dupe_key] = finding
 
-        return dupes.values()
+        return list(dupes.values())
 
     def format_title(self, i):
         if i.channel_version_origin_id is not None:

dojo/tools/blackduck_binary_analysis/parser.py

@@ -104,7 +104,7 @@ def ingest_findings(self, sorted_findings, test):
 
                 findings[unique_finding_key] = finding
 
-        return findings.values()
+        return list(findings.values())
 
     def format_title(self, i):
         title = f"{i.object_name}: {i.component} {i.version} Vulnerable"

dojo/tools/h1/parser.py

@@ -100,7 +100,7 @@ def get_vulnerability_disclosure_json_findings(self, tree, test):
                 )
                 finding.unsaved_endpoints = []
                 dupes[dupe_key] = finding
-        return dupes.values()
+        return list(dupes.values())
 
     def build_description(self, content):
         date = content["attributes"]["created_at"]

dojo/tools/intsights/parser.py

@@ -71,4 +71,4 @@ def get_findings(self, file, test):
             duplicates[dupe_key] = alert
             if dupe_key not in duplicates:
                 duplicates[dupe_key] = True
-        return duplicates.values()
+        return list(duplicates.values())

dojo/tools/mend/parser.py

@@ -161,4 +161,4 @@ def create_finding_key(f: Finding) -> str:
             if dupe_key not in dupes:
                 dupes[dupe_key] = finding
 
-        return dupes.values()
+        return list(dupes.values())

dojo/tools/qualys_webapp/parser.py

@@ -462,7 +462,7 @@ def qualys_webapp_parser(qualys_xml_file, test, unique, enable_weakness=False):
             ).values(),
         )
 
-    return items
+    return list(items)
 
 
 class QualysWebAppParser:

dojo/tools/sslscan/parser.py

@@ -93,4 +93,4 @@ def get_findings(self, file, test):
                             else:
                                 endpoint = Endpoint(host=host, port=port)
                             finding.unsaved_endpoints.append(endpoint)
-        return dupes.values()
+        return list(dupes.values())

dojo/tools/sslyze/parser_xml.py

@@ -161,4 +161,4 @@ def get_findings(self, file, test):
                                     host=host, port=port, protocol=protocol,
                                 ),
                             )
-        return dupes.values()
+        return list(dupes.values())

dojo/tools/whitehat_sentinel/parser.py

@@ -268,4 +268,4 @@ def _convert_whitehat_sentinel_vulns_to_dojo_finding(
                 finding.unsaved_endpoints = endpoints
                 dupes[dupe_key] = finding
 
-        return dupes.values()
+        return list(dupes.values())