Skip to content

Commit 6e5e1f9

Browse files
committed
Set unique_id_from_tool from matrix field in Dependency Track parser
1 parent 02998c6 commit 6e5e1f9

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

dojo/tools/dependency_track/parser.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,7 @@ def _convert_dependency_track_finding_to_dojo_finding(self, dependency_track_fin
230230
component_version=component_version,
231231
file_path=file_path,
232232
vuln_id_from_tool=vuln_id_from_tool,
233+
unique_id_from_tool=dependency_track_finding.get("matrix"),
233234
static_finding=True,
234235
dynamic_finding=False)
235236

unittests/tools/test_dependency_track_parser.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,10 @@ def test_dependency_track_parser_has_one_finding(self):
5454
parser = DependencyTrackParser()
5555
findings = parser.get_findings(testfile, Test())
5656
self.assertEqual(1, len(findings))
57+
self.assertEqual(
58+
"ca4f2da9-0fad-4a13-92d7-f627f3168a56:b815b581-fec1-4374-a871-68862a8f8d52:115b80bb-46c4-41d1-9f10-8a175d4abb46",
59+
findings[0].unique_id_from_tool,
60+
)
5761

5862
def test_dependency_track_parser_v3_8_0(self):
5963
with (
@@ -64,6 +68,7 @@ def test_dependency_track_parser_v3_8_0(self):
6468
self.assertEqual(9, len(findings))
6569
self.assertTrue(all(item.file_path is not None for item in findings))
6670
self.assertTrue(all(item.vuln_id_from_tool is not None for item in findings))
71+
self.assertTrue(all(item.unique_id_from_tool is not None for item in findings))
6772

6873
def test_dependency_track_parser_findings_with_alias(self):
6974
with (
@@ -75,6 +80,7 @@ def test_dependency_track_parser_findings_with_alias(self):
7580
self.assertEqual(12, len(findings))
7681
self.assertTrue(all(item.file_path is not None for item in findings))
7782
self.assertTrue(all(item.vuln_id_from_tool is not None for item in findings))
83+
self.assertTrue(all(item.unique_id_from_tool is not None for item in findings))
7884
self.assertIn("CVE-2022-42004", findings[0].unsaved_vulnerability_ids)
7985

8086
def test_dependency_track_parser_findings_with_empty_alias(self):
@@ -94,6 +100,7 @@ def test_dependency_track_parser_findings_with_cvssV3_score(self):
94100
self.assertEqual(12, len(findings))
95101
self.assertTrue(all(item.file_path is not None for item in findings))
96102
self.assertTrue(all(item.vuln_id_from_tool is not None for item in findings))
103+
self.assertTrue(all(item.unique_id_from_tool is not None for item in findings))
97104
self.assertIn("CVE-2022-42004", findings[0].unsaved_vulnerability_ids)
98105
self.assertEqual(8.3, findings[0].cvssv3_score)
99106

0 commit comments

Comments
 (0)