Support sync kwarg in process_findings for inline post-processing

Thread the sync kwarg from process_findings through to dojo_dispatch_task
in both DefaultImporter and DefaultReImporter so callers can force
post_process_findings_batch to run inline instead of spawning additional
Celery tasks. Pop sync from kwargs in sync_process_findings to avoid
duplicate keyword argument errors.

Author: valentijnscholten

dojo/importers/base_importer.py

@@ -293,6 +293,9 @@ def sync_process_findings(
         Processes findings in a synchronous manner such that all findings
         will be processed in a worker/process/thread
         """
+        # Pop sync from kwargs to avoid "multiple values" TypeError when
+        # callers (e.g. async importer) pass sync=True through the kwargs chain
+        kwargs.pop("sync", None)
         return self.process_findings(parsed_findings, sync=True, **kwargs)
 
     def determine_process_method(

dojo/importers/default_importer.py

@@ -167,6 +167,8 @@ def process_findings(
         # Batched post-processing (no chord): dispatch a task per 1000 findings or on final finding
         batch_finding_ids: list[int] = []
         batch_max_size = getattr(settings, "IMPORT_REIMPORT_DEDUPE_BATCH_SIZE", 1000)
+        # Allow callers to force synchronous dispatch of post-processing sub-tasks
+        sync = kwargs.pop("sync", False)
 
         """
         Saves findings in memory that were parsed from the scan report into the database.
@@ -275,6 +277,7 @@ def process_findings(
                     product_grading_option=True,
                     issue_updater_option=True,
                     push_to_jira=push_to_jira,
+                    sync=sync,
                 )
 
             # No chord: tasks are dispatched immediately above per batch

dojo/importers/default_reimporter.py

@@ -267,6 +267,8 @@ def process_findings(
         the finding may be appended to a new or existing group based upon user selection
         at import time
         """
+        # Allow callers to force synchronous dispatch of post-processing sub-tasks
+        sync = kwargs.pop("sync", False)
         self.deduplication_algorithm = self.determine_deduplication_algorithm()
         # Only process findings with the same service value (or None)
         # Even though the service values is used in the hash_code calculation,
@@ -443,6 +445,7 @@ def process_findings(
                             issue_updater_option=True,
                             push_to_jira=push_to_jira,
                             jira_instance_id=getattr(self.jira_instance, "id", None),
+                            sync=sync,
                         )
 
         # No chord: tasks are dispatched immediately above per batch