Skip to content

Commit 4e29d72

Browse files
authored
Engagement: Add missing permission check to view an Engagement (#10639)
1 parent 6bfe49b commit 4e29d72

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

dojo/engagement/views.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -440,6 +440,8 @@ def get_filtered_tests(
440440

441441
def get(self, request, eid, *args, **kwargs):
442442
eng = get_object_or_404(Engagement, id=eid)
443+
# Make sure the user is authorized
444+
user_has_permission_or_403(request.user, eng, Permissions.Engagement_View)
443445
tests = eng.test_set.all().order_by('test_type__name', '-updated')
444446
default_page_num = 10
445447
tests_filter = self.get_filtered_tests(request, tests, eng)
@@ -508,6 +510,8 @@ def get(self, request, eid, *args, **kwargs):
508510

509511
def post(self, request, eid, *args, **kwargs):
510512
eng = get_object_or_404(Engagement, id=eid)
513+
# Make sure the user is authorized
514+
user_has_permission_or_403(request.user, eng, Permissions.Engagement_View)
511515
tests = eng.test_set.all().order_by('test_type__name', '-updated')
512516

513517
default_page_num = 10

0 commit comments

Comments
 (0)