Ruff: Add and fix B006 (#11951)

Co-authored-by: Matt Tesauro <mtesauro@gmail.com>

Author: kiblik

dojo/importers/base_importer.py

@@ -329,13 +329,21 @@ def update_test_tags(self):
 
     def update_import_history(
         self,
-        new_findings: list[Finding] = [],
-        closed_findings: list[Finding] = [],
-        reactivated_findings: list[Finding] = [],
-        untouched_findings: list[Finding] = [],
+        new_findings: list[Finding] | None = None,
+        closed_findings: list[Finding] | None = None,
+        reactivated_findings: list[Finding] | None = None,
+        untouched_findings: list[Finding] | None = None,
     ) -> Test_Import:
         """Creates a record of the import or reimport operation that has occurred."""
         # Quick fail check to determine if we even wanted this
+        if untouched_findings is None:
+            untouched_findings = []
+        if reactivated_findings is None:
+            reactivated_findings = []
+        if closed_findings is None:
+            closed_findings = []
+        if new_findings is None:
+            new_findings = []
         if settings.TRACK_IMPORT_HISTORY is False:
             return None
         # Log the current state of what has occurred in case there could be
@@ -763,11 +771,19 @@ def notify_scan_added(
         self,
         test,
         updated_count,
-        new_findings=[],
-        findings_mitigated=[],
-        findings_reactivated=[],
-        findings_untouched=[],
+        new_findings=None,
+        findings_mitigated=None,
+        findings_reactivated=None,
+        findings_untouched=None,
     ):
+        if findings_untouched is None:
+            findings_untouched = []
+        if findings_reactivated is None:
+            findings_reactivated = []
+        if findings_mitigated is None:
+            findings_mitigated = []
+        if new_findings is None:
+            new_findings = []
         logger.debug("Scan added notifications")
 
         new_findings = sorted(new_findings, key=lambda x: x.numerical_severity)

dojo/importers/options.py

@@ -182,7 +182,7 @@ def set_dict_fields(
     def validate(
         self,
         field_name: str,
-        expected_types: list[Callable] = [],
+        expected_types: list[Callable] | None = None,
         *,
         required: bool = False,
         default: Any = None,
@@ -193,6 +193,8 @@ def validate(
         and ensures it is the correct type before returning it
         """
         # Get the value from the kwargs
+        if expected_types is None:
+            expected_types = []
         value = kwargs.get(field_name)
         # Make sure we have something if we need it
         if required is True:

dojo/jira_link/helper.py

@@ -742,8 +742,10 @@ def prepare_jira_issue_fields(
         epic_name_field=None,
         default_assignee=None,
         duedate=None,
-        issuetype_fields=[]):
+        issuetype_fields=None):
 
+    if issuetype_fields is None:
+        issuetype_fields = []
     fields = {
             "project": {"key": project_key},
             "issuetype": {"name": issuetype_name},

dojo/models.py

@@ -101,8 +101,10 @@ def _get_statistics_for_queryset(qs, annotation_factory):
     return stats
 
 
-def _manage_inherited_tags(obj, incoming_inherited_tags, potentially_existing_tags=[]):
+def _manage_inherited_tags(obj, incoming_inherited_tags, potentially_existing_tags=None):
     # get copies of the current tag lists
+    if potentially_existing_tags is None:
+        potentially_existing_tags = []
     current_inherited_tags = [] if isinstance(obj.inherited_tags, FakeTagRelatedManager) else [tag.name for tag in obj.inherited_tags.all()]
     tag_list = potentially_existing_tags if isinstance(obj.tags, FakeTagRelatedManager) or len(potentially_existing_tags) > 0 else [tag.name for tag in obj.tags.all()]
     # Clean existing tag list from the old inherited tags. This represents the tags on the object and not the product
@@ -123,7 +125,9 @@ def _manage_inherited_tags(obj, incoming_inherited_tags, potentially_existing_ta
             obj.tags.set(cleaned_tag_list)
 
 
-def _copy_model_util(model_in_database, exclude_fields: list[str] = []):
+def _copy_model_util(model_in_database, exclude_fields: list[str] | None = None):
+    if exclude_fields is None:
+        exclude_fields = []
     new_model_instance = model_in_database.__class__()
     for field in model_in_database._meta.fields:
         if field.name not in {"id", *exclude_fields}:

dojo/tags_signals.py

@@ -46,8 +46,10 @@ def inherit_tags_on_instance(sender, instance, created, **kwargs):
             instance.inherit_tags(tag_list)
 
 
-def propagate_inheritance(instance, tag_list=[]):
+def propagate_inheritance(instance, tag_list=None):
     # Get the expected product tags
+    if tag_list is None:
+        tag_list = []
     product_inherited_tags = [tag.name for tag in get_product(instance).tags.all()]
     existing_inherited_tags = [tag.name for tag in instance.inherited_tags.all()]
     # Check if product tags already matches inherited tags

ruff.toml

@@ -85,6 +85,7 @@ select = [
    "FURB",
    "DOC202", "DOC403", "DOC502",
    "RUF",
+   "B006",
    "B009",
    "B010",
    "B033",

unittests/dojo_test_case.py

@@ -97,7 +97,9 @@ def create_sla_configuration(self, name, *args, description="dummy description",
         sla_configuration.save()
         return sla_configuration
 
-    def create_product(self, name, *args, description="dummy description", prod_type=None, tags=[], **kwargs):
+    def create_product(self, name, *args, description="dummy description", prod_type=None, tags=None, **kwargs):
+        if tags is None:
+            tags = []
         if not prod_type:
             prod_type = Product_Type.objects.first()
         product = Product(name=name, description=description, prod_type=prod_type, tags=tags)