udpate

Author: manuel-sommer

dojo/tools/stackhawk/parser.py

@@ -14,7 +14,6 @@ def __init__(self, completed_scan):
         self.component_version = completed_scan["scan"]["env"]
         self.static_finding = False
         self.dynamic_finding = True
-        self.service = completed_scan["scan"]["application"]
 
 
 class StackHawkParser:
@@ -106,7 +105,6 @@ def __extract_finding(
             dynamic_finding=metadata.dynamic_finding,
             vuln_id_from_tool=raw_finding["pluginId"],
             nb_occurences=raw_finding["totalCount"],
-            service=metadata.service,
             false_p=are_all_endpoints_false_positive,
             risk_accepted=are_all_endpoints_risk_accepted,
         )

unittests/test_importers_performance.py

@@ -201,7 +201,6 @@ def _import_reimport_performance(
                                 "verified": True,
                                 "sync": True,
                                 "scan_type": scan_type,
-                                "service": "Secured Application",
                                 "tags": ["performance-test-reimport", "reimport-tag-in-param", "reimport-go-faster"],
                                 "apply_tags_to_findings": True,
                             }
@@ -231,7 +230,6 @@ def _import_reimport_performance(
                                 "verified": True,
                                 "sync": True,
                                 "scan_type": scan_type,
-                                "service": "Secured Application",
                             }
                             reimporter = DefaultReImporter(**reimport_options)
                             test, _, _len_new_findings, _len_closed_findings, _, _, _ = reimporter.process_scan(scan)
@@ -259,9 +257,6 @@ def _import_reimport_performance(
                                 "verified": True,
                                 "sync": True,
                                 "scan_type": scan_type,
-                                # StackHawk parser sets the service field causing close old findings to fail if we do not specify the service field
-                                # This is a big problem that needs fixing. Parsers should not set the service field.
-                                "service": "Secured Application",
                                 "close_old_findings": close_old_findings4,
                             }
                             reimporter = DefaultReImporter(**reimport_options)

unittests/tools/test_stackhawk_parser.py

@@ -243,7 +243,7 @@ def __assertFindingEquals(
         self.assertTrue(actual_finding.dynamic_finding)
         self.assertEqual(finding_id, actual_finding.vuln_id_from_tool)
         self.assertEqual(count, actual_finding.nb_occurences)
-        self.assertEqual(application_name, actual_finding.service)
+        self.assertIsNone(actual_finding.service)
         self.assertEqual(false_positive, actual_finding.false_p)
         self.assertEqual(risk_accepted, actual_finding.risk_accepted)
         # The following fields should be not be set from this parser.