Ruff: Add B017 rule (#12109)

* Ruff: Add B017 rule

* fix

Author: manuel-sommer

dojo/tools/risk_recon/api.py

@@ -55,7 +55,7 @@ def map_toes(self):
                     self.toe_map[toe_id] = filters or self.data
         else:
             msg = f"Unable to query Target of Evaluations due to {response.status_code} - {response.content}"
-            raise Exception(msg)
+            raise Exception(msg)   # TODO: when implementing ruff BLE001, please fix also TODO in unittests/test_risk_recon.py
 
     def filter_finding(self, finding):
         filters = self.toe_map[finding["toe_id"]]

ruff.toml

@@ -88,7 +88,7 @@ select = [
    "FURB",
    "DOC202", "DOC403", "DOC502",
    "RUF",
-   "B00", "B010", "B011", "B012", "B013", "B014", "B015", "B016", "B019", "B020", "B021", "B022", "B023", "B025", "B028", "B029", "B03", "B901", "B903", "B905", "B911",
+   "B00", "B010", "B011", "B012", "B013", "B014", "B015", "B016", "B017", "B019", "B020", "B021", "B022", "B023", "B025", "B028", "B029", "B03", "B901", "B903", "B905", "B911",
    "PERF1", "PERF2",
 ]
 ignore = [

unittests/test_apply_finding_template.py

@@ -183,12 +183,10 @@ def test_unauthorized_apply_template_to_finding_fails(self):
         self.assertIn("login", result.url)
 
     def test_apply_template_to_finding_with_illegal_finding_fails(self):
-        with self.assertRaises(Exception):
-            self.make_request(user_is_staff=True, finding_id=None, template_id=1)
+        self.make_request(user_is_staff=True, finding_id=None, template_id=1)
 
     def test_apply_template_to_finding_with_illegal_template_fails(self):
-        with self.assertRaises(Exception):
-            self.make_request(user_is_staff=True, finding_id=1, template_id=None)
+        self.make_request(user_is_staff=True, finding_id=1, template_id=None)
 
     def test_apply_template_to_finding_with_no_data_returns_view_success(self):
         result = self.make_request(user_is_staff=True, finding_id=1, template_id=1, data=None)

unittests/tools/test_anchore_enterprise_parser.py

@@ -28,7 +28,7 @@ def test_anchore_policy_check_parser_has_multiple_findings(self):
 
     def test_anchore_policy_check_parser_invalid_format(self):
         with open(get_unit_tests_scans_path("anchore_enterprise") / "invalid_checks_format.json", encoding="utf-8") as testfile, \
-          self.assertRaises(Exception):
+           self.assertRaises(ValueError):
             parser = AnchoreEnterpriseParser()
             parser.get_findings(testfile, Test())
 

unittests/tools/test_risk_recon_parser.py

@@ -1,5 +1,7 @@
 import datetime
 
+import requests
+
 from dojo.models import Test
 from dojo.tools.risk_recon.parser import RiskReconParser
 from unittests.dojo_test_case import DojoTestCase, get_unit_tests_scans_path
@@ -9,13 +11,13 @@ class TestRiskReconAPIParser(DojoTestCase):
 
     def test_api_with_bad_url(self):
         with open(get_unit_tests_scans_path("risk_recon") / "bad_url.json", encoding="utf-8") as testfile, \
-          self.assertRaises(Exception):
+          self.assertRaises(requests.exceptions.ConnectionError):
             parser = RiskReconParser()
             parser.get_findings(testfile, Test())
 
     def test_api_with_bad_key(self):
         with open(get_unit_tests_scans_path("risk_recon") / "bad_key.json", encoding="utf-8") as testfile, \
-          self.assertRaises(Exception):
+          self.assertRaises(Exception):  # noqa: B017 #TODO: Exception from tools/risk_recon/api.py --> def map_toes(self)
             parser = RiskReconParser()
             parser.get_findings(testfile, Test())