Refactor JIRA sync flag to use 'finding_jira_sync' for consistency in importers and reimporters

Author: Maffooch

dojo/finding/helper.py

@@ -521,7 +521,7 @@ def post_process_findings_batch(
             jira_instance = JIRA_Instance.objects.get(id=jira_instance_id)
     # We dont check if the finding jira sync is applicable quite yet until we can get in the loop
         # but this is a way to at least make it that far
-    if push_to_jira or getattr(jira_instance, "keep_findings_jira_sync", False):
+    if push_to_jira or getattr(jira_instance, "finding_jira_sync", False):
         for finding in findings:
             object_to_push = finding if finding.has_jira_issue or not finding.finding_group else finding.finding_group
             # Check the push_to_jira flag again to potentially shorty circuit without checking for existing findings

dojo/importers/default_importer.py

@@ -384,7 +384,7 @@ def close_old_findings(
         # push finding groups to jira since we only only want to push whole groups
         # We dont check if the finding jira sync is applicable quite yet until we can get in the loop
         # but this is a way to at least make it that far
-        if self.findings_groups_enabled and (self.push_to_jira or getattr(self.jira_instance, "keep_findings_jira_sync", False)):
+        if self.findings_groups_enabled and (self.push_to_jira or getattr(self.jira_instance, "finding_jira_sync", False)):
             for finding_group in {finding.finding_group for finding in old_findings if finding.finding_group is not None}:
                 # Check the push_to_jira flag again to potentially shorty circuit without checking for existing findings
                 if self.push_to_jira or is_keep_in_sync_with_jira(finding_group, prefetched_jira_instance=self.jira_instance):

dojo/importers/default_reimporter.py

@@ -501,7 +501,7 @@ def close_old_findings(
         # push finding groups to jira since we only only want to push whole groups
         # We dont check if the finding jira sync is applicable quite yet until we can get in the loop
         # but this is a way to at least make it that far
-        if self.findings_groups_enabled and (self.push_to_jira or getattr(self.jira_instance, "keep_findings_jira_sync", False)):
+        if self.findings_groups_enabled and (self.push_to_jira or getattr(self.jira_instance, "finding_jira_sync", False)):
             for finding_group in {finding.finding_group for finding in findings if finding.finding_group is not None}:
                 # Check the push_to_jira flag again to potentially shorty circuit without checking for existing findings
                 if self.push_to_jira or is_keep_in_sync_with_jira(finding_group, prefetched_jira_instance=self.jira_instance):
@@ -990,14 +990,14 @@ def process_groups_for_all_findings(
             )
             # We dont check if the finding jira sync is applicable quite yet until we can get in the loop
             # but this is a way to at least make it that far
-            if self.push_to_jira or getattr(self.jira_instance, "keep_findings_jira_sync", False):
+            if self.push_to_jira or getattr(self.jira_instance, "finding_jira_sync", False):
                 object_to_push = findings[0].finding_group if findings[0].finding_group is not None else findings[0]
                 # Check the push_to_jira flag again to potentially shorty circuit without checking for existing findings
                 if self.push_to_jira or is_keep_in_sync_with_jira(object_to_push, prefetched_jira_instance=self.jira_instance):
                     jira_helper.push_to_jira(object_to_push)
         # We dont check if the finding jira sync is applicable quite yet until we can get in the loop
         # but this is a way to at least make it that far
-        if self.findings_groups_enabled and (self.push_to_jira or getattr(self.jira_instance, "keep_findings_jira_sync", False)):
+        if self.findings_groups_enabled and (self.push_to_jira or getattr(self.jira_instance, "finding_jira_sync", False)):
             for finding_group in {
                     finding.finding_group
                     for finding in self.reactivated_items + self.unchanged_items