Ruff: Add and fix ARG003,4,5 (#10702)

Author: kiblik

dojo/filters.py

@@ -605,7 +605,7 @@ def __init__(self, *args, **kwargs):
 
 class DateRangeFilter(ChoiceFilter):
     options = {
-        None: (_("Any date"), lambda qs, name: qs.all()),
+        None: (_("Any date"), lambda qs, _: qs.all()),
         1: (_("Today"), lambda qs, name: qs.filter(**{
             f"{name}__year": now().year,
             f"{name}__month": now().month,
@@ -651,7 +651,7 @@ def filter(self, qs, value):
 
 class DateRangeOmniFilter(ChoiceFilter):
     options = {
-        None: (_("Any date"), lambda qs, name: qs.all()),
+        None: (_("Any date"), lambda qs, _: qs.all()),
         1: (_("Today"), lambda qs, name: qs.filter(**{
             f"{name}__year": now().year,
             f"{name}__month": now().month,
@@ -713,7 +713,7 @@ def filter(self, qs, value):
 
 class ReportBooleanFilter(ChoiceFilter):
     options = {
-        None: (_("Either"), lambda qs, name: qs.all()),
+        None: (_("Either"), lambda qs, _: qs.all()),
         1: (_("Yes"), lambda qs, name: qs.filter(**{
             f"{name}": True,
         })),
@@ -3238,7 +3238,7 @@ class Meta:
         filter_overrides = {
             JSONField: {
                 "filter_class": CharFilter,
-                "extra": lambda f: {
+                "extra": lambda _: {
                     "lookup_expr": "icontains",
                 },
             },

dojo/middleware.py

@@ -92,7 +92,7 @@ def get_system_settings(cls):
         return None
 
     @classmethod
-    def cleanup(cls, *args, **kwargs):
+    def cleanup(cls, *args, **kwargs):  # noqa: ARG003
         if hasattr(cls._thread_local, "system_settings"):
             del cls._thread_local.system_settings
 

dojo/tools/nexpose/parser.py

@@ -287,7 +287,7 @@ def get_items(self, tree, vulns, test):
             for vuln in host["vulns"]:
                 dupe_key = vuln["severity"] + vuln["name"]
 
-                find = self.findings(dupe_key, dupes, test, vuln)
+                find = self.findings(dupe_key, dupes, vuln)
 
                 endpoint = Endpoint(host=host["name"])
                 find.unsaved_endpoints.append(endpoint)
@@ -298,7 +298,7 @@ def get_items(self, tree, vulns, test):
                 for vuln in service["vulns"]:
                     dupe_key = vuln["severity"] + vuln["name"]
 
-                    find = self.findings(dupe_key, dupes, test, vuln)
+                    find = self.findings(dupe_key, dupes, vuln)
 
                     endpoint = Endpoint(
                         host=host["name"],
@@ -318,7 +318,7 @@ def get_items(self, tree, vulns, test):
         return list(dupes.values())
 
     @staticmethod
-    def findings(dupe_key, dupes, test, vuln):
+    def findings(dupe_key, dupes, vuln):
         """ """
         if dupe_key in dupes:
             find = dupes[dupe_key]

dojo/tools/veracode/xml_parser.py

@@ -277,7 +277,7 @@ def _get_cwe(val):
 
     @classmethod
     def __xml_sca_flaw_to_finding(
-        cls, test, report_date, vendor, library, version, xml_node,
+        cls, test, report_date, _vendor, library, version, xml_node,
     ):
         # Defaults
         finding = Finding()

dojo/urls.py

@@ -240,7 +240,7 @@
     re_path(r"^{}api/v2/oa3/schema/".format(get_system_setting("url_prefix")), SpectacularAPIView.as_view(), name="schema_oa3"),
     re_path(r"^{}api/v2/oa3/swagger-ui/".format(get_system_setting("url_prefix")), SpectacularSwaggerView.as_view(url=get_system_setting("url_prefix") + "/api/v2/oa3/schema/?format=json"), name="swagger-ui_oa3"),
 
-    re_path(r"^robots.txt", lambda x: HttpResponse("User-Agent: *\nDisallow: /", content_type="text/plain"), name="robots_file"),
+    re_path(r"^robots.txt", lambda _: HttpResponse("User-Agent: *\nDisallow: /", content_type="text/plain"), name="robots_file"),
     re_path(r"^manage_files/(?P<oid>\d+)/(?P<obj_type>\w+)$", views.manage_files, name="manage_files"),
     re_path(r"^access_file/(?P<fid>\d+)/(?P<oid>\d+)/(?P<obj_type>\w+)$", views.access_file, name="access_file"),
     re_path(r"^{}/(?P<path>.*)$".format(settings.MEDIA_URL.strip("/")), views.protected_serve, {"document_root": settings.MEDIA_ROOT}),

ruff.toml

@@ -61,6 +61,7 @@ select = [
    "TID",
    "TCH",
    "INT",
+   "ARG003", "ARG004", "ARG005",
    "PTH2",
    "TD001", "TD004", "TD005",
    "PD",