Ruff: Add PLC1901 (#13157)

* Ruff: Add PLC1901

* fix

* fix

* fix

* fix

* fix

* fix

Author: manuel-sommer

dojo/filters.py

@@ -2269,7 +2269,7 @@ class MetricsFindingFilter(FindingFilter):
 
     def __init__(self, *args, **kwargs):
         if args[0]:
-            if args[0].get("start_date", "") != "" or args[0].get("end_date", "") != "":
+            if args[0].get("start_date", "") or args[0].get("end_date", ""):
                 args[0]._mutable = True
                 args[0]["date"] = 8
                 args[0]._mutable = False
@@ -2299,7 +2299,7 @@ class MetricsFindingFilterWithoutObjectLookups(FindingFilterWithoutObjectLookups
 
     def __init__(self, *args, **kwargs):
         if args[0]:
-            if args[0].get("start_date", "") != "" or args[0].get("end_date", "") != "":
+            if args[0].get("start_date", "") or args[0].get("end_date", ""):
                 args[0]._mutable = True
                 args[0]["date"] = 8
                 args[0]._mutable = False
@@ -2388,7 +2388,7 @@ class MetricsEndpointFilter(MetricsEndpointFilterHelper):
 
     def __init__(self, *args, **kwargs):
         if args[0]:
-            if args[0].get("start_date", "") != "" or args[0].get("end_date", "") != "":
+            if args[0].get("start_date", "") or args[0].get("end_date", ""):
                 args[0]._mutable = True
                 args[0]["date"] = 8
                 args[0]._mutable = False
@@ -2550,7 +2550,7 @@ class MetricsEndpointFilterWithoutObjectLookups(MetricsEndpointFilterHelper, Fin
 
     def __init__(self, *args, **kwargs):
         if args[0]:
-            if args[0].get("start_date", "") != "" or args[0].get("end_date", "") != "":
+            if args[0].get("start_date", "") or args[0].get("end_date", ""):
                 args[0]._mutable = True
                 args[0]["date"] = 8
                 args[0]._mutable = False

dojo/finding/views.py

@@ -324,7 +324,7 @@ def add_breadcrumbs(self, request: HttpRequest, context: dict):
         # show custom breadcrumb if user has filtered by exactly 1 endpoint
         if "endpoints" in request.GET:
             endpoint_ids = request.GET.getlist("endpoints", [])
-            if len(endpoint_ids) == 1 and endpoint_ids[0] != "":
+            if len(endpoint_ids) == 1 and endpoint_ids[0]:
                 endpoint_id = endpoint_ids[0]
                 endpoint = get_object_or_404(Endpoint, id=endpoint_id)
                 context["filter_name"] = "Vulnerable Endpoints"
@@ -2471,7 +2471,7 @@ def merge_finding_product(request, pid):
                                 finding.tags.add("merged-inactive")
 
                     # Update the finding to merge into
-                    if finding_descriptions != "":
+                    if finding_descriptions:
                         finding_to_merge_into.description = f"{finding_to_merge_into.description}\n\n{finding_descriptions}"
 
                     if finding_to_merge_into.static_finding:
@@ -2480,7 +2480,7 @@ def merge_finding_product(request, pid):
                     if finding_to_merge_into.dynamic_finding:
                         dynamic = finding.dynamic_finding
 
-                    if finding_references != "":
+                    if finding_references:
                         finding_to_merge_into.references = f"{finding_to_merge_into.references}\n{finding_references}"
 
                     finding_to_merge_into.static_finding = static

dojo/pipeline.py

@@ -71,7 +71,7 @@ def update_azure_groups(backend, uid, user=None, social=None, *args, **kwargs):
         soc = user.social_auth.order_by("-created").first()
         token = soc.extra_data["access_token"]
         group_names = []
-        if "groups" not in kwargs["response"] or kwargs["response"]["groups"] == "":
+        if "groups" not in kwargs["response"] or not kwargs["response"]["groups"]:
             logger.warning("No groups in response. Stopping to update groups of user based on azureAD")
             return
         group_IDs = kwargs["response"]["groups"]
@@ -93,7 +93,7 @@ def update_azure_groups(backend, uid, user=None, social=None, *args, **kwargs):
                     logger.debug("detected " + group_from_response + " as group name and will not call microsoft graph")
                     group_name = group_from_response
 
-                if settings.AZUREAD_TENANT_OAUTH2_GROUPS_FILTER == "" or re.search(settings.AZUREAD_TENANT_OAUTH2_GROUPS_FILTER, group_name):
+                if not settings.AZUREAD_TENANT_OAUTH2_GROUPS_FILTER or re.search(settings.AZUREAD_TENANT_OAUTH2_GROUPS_FILTER, group_name):
                     group_names.append(group_name)
                 else:
                     logger.debug("Skipping group " + group_name + " due to AZUREAD_TENANT_OAUTH2_GROUPS_FILTER " + settings.AZUREAD_TENANT_OAUTH2_GROUPS_FILTER)

dojo/settings/settings.dist.py

@@ -1643,7 +1643,7 @@ def saml2_attrib_map_format(din):
     ("Security", "Security"),
 )
 
-if env("DD_JIRA_EXTRA_ISSUE_TYPES") != "":
+if env("DD_JIRA_EXTRA_ISSUE_TYPES"):
     for extra_type in env("DD_JIRA_EXTRA_ISSUE_TYPES").split(","):
         JIRA_ISSUE_TYPE_CHOICES_CONFIG += ((extra_type, extra_type),)
 

dojo/templatetags/display_tags.py

@@ -303,8 +303,7 @@ def product_grade(product):
     system_settings = System_Settings.objects.get()
     if system_settings.enable_product_grade and product:
         prod_numeric_grade = product.prod_numeric_grade
-
-        if prod_numeric_grade == "" or prod_numeric_grade is None:
+        if not prod_numeric_grade or prod_numeric_grade is None:
             calculate_grade(product)
         if prod_numeric_grade:
             if prod_numeric_grade >= system_settings.product_grade_a:
@@ -360,7 +359,7 @@ def datediff_time(date1, date2):
         date_str = date_str + date_part + " "
 
     # Date is for one day
-    if date_str == "":
+    if not date_str:
         date_str = "1 day"
 
     return date_str

dojo/templatetags/navigation_tags.py

@@ -30,7 +30,7 @@ def query_string_as_hidden(context):
 
 @register.simple_tag
 def url_replace(request, field="page", value=1):
-    if field is None or field == "":
+    if field is None or not field:
         field = "page"
     dict_ = request.GET.copy()
     dict_[field] = value

dojo/tools/acunetix/parse_acunetix_xml.py

@@ -70,7 +70,7 @@ def get_findings(self, filename, test):
             if ":" not in start_url:
                 start_url = "//" + start_url
             # get report date
-            if scan.findtext("StartTime") and scan.findtext("StartTime") != "":
+            if scan.findtext("StartTime") and scan.findtext("StartTime"):
                 report_date = dateutil.parser.parse(
                     scan.findtext("StartTime"), dayfirst=True,
                 ).date()
@@ -89,11 +89,11 @@ def get_findings(self, filename, test):
                     dynamic_finding=False,
                     nb_occurences=1,
                 )
-                if item.findtext("Impact") and item.findtext("Impact") != "":
+                if item.findtext("Impact") and item.findtext("Impact"):
                     finding.impact = item.findtext("Impact")
                 if item.findtext("Recommendation") and item.findtext(
                     "Recommendation",
-                ) != "":
+                ):
                     finding.mitigation = item.findtext("Recommendation")
                 if report_date:
                     finding.date = report_date
@@ -151,7 +151,7 @@ def get_findings(self, filename, test):
                     port=url.port,
                     path=item.findtext("Affects"),
                 )
-                if url.scheme is not None and url.scheme != "":
+                if url.scheme is not None and url.scheme:
                     endpoint.protocol = url.scheme
                 finding.unsaved_endpoints = [endpoint]
                 dupe_key = hashlib.sha256(

dojo/tools/api_bugcrowd/api_client.py

@@ -52,7 +52,7 @@ def get_findings(self, program, target):
             params_encoded = urlencode(params_default)
 
         next_page = f"{self.bugcrowd_api_url}/submissions?{params_encoded}"
-        while next_page != "":
+        while next_page:
             response = self.session.get(
                 url=next_page,
                 timeout=settings.REQUESTS_TIMEOUT,

dojo/tools/api_vulners/parser.py

@@ -110,7 +110,7 @@ def get_findings(self, file, test):
                 for ref in external_references:
                     references += f"{ref} \n"
 
-            if references != "":
+            if references:
                 finding.references = references
 
             findings.append(finding)

dojo/tools/aws_prowler_v3plus/prowler_v3.py

@@ -37,7 +37,7 @@ def process_json(self, file, test):
             account_id = deserialized.get("AccountId")
             resource_id = deserialized.get("ResourceId")
             unique_id_from_tool = deserialized.get("FindingUniqueId")
-            if not resource_arn or resource_arn == "":
+            if not resource_arn:
                 component_name = str(provider) + "-" + str(account_id) + "-" + str(region) + "-" + str(resource_id)
             else:
                 component_name = resource_arn