Skip to content

Commit 21eae4f

Browse files
authored
Permission fixes (#10713)
1 parent 7007667 commit 21eae4f

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

dojo/cred/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def new_cred(request):
3838
return render(request, "dojo/new_cred.html", {"tform": tform})
3939

4040

41-
@user_is_authorized(Product, Permissions.Product_View, "pid")
41+
@user_is_authorized(Product, Permissions.Product_Edit, "pid")
4242
def all_cred_product(request, pid):
4343
prod = get_object_or_404(Product, id=pid)
4444
creds = Cred_Mapping.objects.filter(product=prod).order_by("cred_id__name")

dojo/endpoint/views.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
from django.conf import settings
77
from django.contrib import messages
88
from django.contrib.admin.utils import NestedObjects
9+
from django.core.exceptions import PermissionDenied
910
from django.db import DEFAULT_DB_ALIAS
1011
from django.db.models import Count, Q, QuerySet
1112
from django.http import HttpResponseRedirect
@@ -178,7 +179,7 @@ def view_endpoint_host(request, eid):
178179
return process_endpoint_view(request, eid, host_view=True)
179180

180181

181-
@user_is_authorized(Endpoint, Permissions.Endpoint_View, "eid")
182+
@user_is_authorized(Endpoint, Permissions.Endpoint_Edit, "eid")
182183
def edit_endpoint(request, eid):
183184
endpoint = get_object_or_404(Endpoint, id=eid)
184185

@@ -468,6 +469,9 @@ def prefetch_for_endpoints(endpoints):
468469

469470
def migrate_endpoints_view(request):
470471

472+
if not request.user.is_superuser:
473+
raise PermissionDenied
474+
471475
view_name = "Migrate endpoints"
472476

473477
html_log = clean_hosts_run(apps=apps, change=(request.method == "POST"))

0 commit comments

Comments
 (0)