Skip to content

Commit 023485d

Browse files
committed
Refactor check_post_permission to use list type for post_pk parameter
1 parent 79d9198 commit 023485d

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

dojo/api_v2/permissions.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import re
2-
from collections.abc import Iterable
32

43
from django.db.models import Model
54
from django.shortcuts import get_object_or_404
@@ -32,11 +31,11 @@
3231
)
3332

3433

35-
def check_post_permission(request: Request, post_model: Model, post_pk: str | Iterable[str], post_permission: int) -> bool:
34+
def check_post_permission(request: Request, post_model: Model, post_pk: str | list[str], post_permission: int) -> bool:
3635
if request.method == "POST":
3736
eligible_post_pk = None
3837
# Support both single PK string and list of PK strings
39-
searchable_post_pks = post_pk if isinstance(post_pk, Iterable) else [post_pk]
38+
searchable_post_pks = post_pk if isinstance(post_pk, list) else [post_pk]
4039
# Iterate until we find a matching PK in the request data
4140
for pk in searchable_post_pks:
4241
if request.data.get(pk) is not None:

0 commit comments

Comments
 (0)