From 259fc369da98415316e034d693889f1847842188 Mon Sep 17 00:00:00 2001 From: Darrell van Swinderen Date: Wed, 23 Sep 2026 11:17:49 +0200 Subject: [PATCH] fix(streamdeck): the discard key's clip is visible, not buried under a scrim The whole thumbnail was darkened by 45% (62% when kept) so the mark read over it, which left the clip itself barely visible on the key's LCD, and the clip is the point of that key. The picture now stays at 92% (70% when kept, so a protected clip still reads as not on offer), and the mark sits on a small dark disc of its own instead, smaller, so it reads over any frame without hiding it. Plugin 0.4.1. Co-Authored-By: Claude Opus 5.5 (1M context) --- .../manifest.json | 2 +- streamdeck-plugin/src/actions/discard-latest.ts | 14 +++++++++----- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/streamdeck-plugin/io.github.darrellvs.goodbit.sdPlugin/manifest.json b/streamdeck-plugin/io.github.darrellvs.goodbit.sdPlugin/manifest.json index fddacf8..2c7626a 100644 --- a/streamdeck-plugin/io.github.darrellvs.goodbit.sdPlugin/manifest.json +++ b/streamdeck-plugin/io.github.darrellvs.goodbit.sdPlugin/manifest.json @@ -2,7 +2,7 @@ "$schema": "https://schemas.elgato.com/streamdeck/plugins/manifest.json", "UUID": "io.github.darrellvs.goodbit", "Name": "GoodBit", - "Version": "0.4.0.0", + "Version": "0.4.1.0", "Author": "GoodBit", "Description": "Save the replay, then tag, publish or discard the clip you just saved, and see today's count, without leaving the game. Needs GoodBit running with the Stream Deck connection switched on in Settings, Connections.", "URL": "https://darrellvs.github.io/goodbit/", diff --git a/streamdeck-plugin/src/actions/discard-latest.ts b/streamdeck-plugin/src/actions/discard-latest.ts index bac123f..811e4c5 100644 --- a/streamdeck-plugin/src/actions/discard-latest.ts +++ b/streamdeck-plugin/src/actions/discard-latest.ts @@ -117,9 +117,12 @@ export class DiscardLatest extends SingletonAction { /** * The key's face as an SVG data URL, or '' for the plain icon from the manifest. * - * 144 square. The thumbnail fills it, darkened so the mark reads over any - * frame, and the mark sits in the middle: trash in the danger colour, or a - * lock in the light one for a clip that would be kept. + * 144 square. The thumbnail fills it at nearly full brightness, because the + * picture is the point of the key: darkening the whole frame so the mark read + * made the clip itself unreadable on the LCD. The mark sits on a small dark + * disc of its own instead, trash in the danger colour, or a lock in the light + * one for a clip that would be kept, which is dimmed a little more so it reads + * as not on offer. */ function face(preview: Preview): string { if (!preview.thumbnail) return ''; @@ -129,8 +132,9 @@ function face(preview: Preview): string { const svg = ` - - ${glyph} + + + ${glyph} `; return `data:image/svg+xml;base64,${Buffer.from(svg).toString('base64')}`; }