Skip to content

Unnecessary patches that can be worked around with warning flags #6

Description

@slipher

I ran into an issue building GDB for MinGW in the libiberty part, due to the non-existent wait function. I fixed this by adding the -Wno-error=implicit-function-declaration flag as seen in #5. This became an error instead of a warning by default in recent versions of GCC. Later I noticed you must have hit the same issue elsewhere judging by patches/binutils/0003-libiberty-waitpid-c-only-compile-waitpid-when-have-waitpid.patch. Apparently there is a bunch of garbage in there that is compiled to object files but never linked anywhere and if it were linked, it would fail. Probably there are more cases of this with other targets.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions