Issue / context
During the Angular 15 upgrade, @Atmire-Kristof noticed conflicts between the newer versions of the following libraries:
ng-bootstrap
- v14 supports Angular 15 properly
@ng-dynamic-forms
- v16+ claims to support Angular 15, but
@ng-dynamic-forms/ui-ng-bootstrap still requires ng-bootstrap v11 as a peer dependency, which itself doesn't support Angular 15
- After "forcing" the upgrade, builds fail because of inconsistencies between the
ng-bootstrap versions, so this is not a viable workaround
Rather than do a half-upgrade we opted to leave both of these libraries as-is for now. This leads to peer dependency mismatch warnings, but everything remains functional.
Solution
It looks like development of @ng-dynamic-forms has slowed down as of late, and this version mismatch is a bit of a red flag. Therefore, we should consider moving away from this library and use the default Angular forms instead for more stability.
This would involve a significant refactor of DSpace Angular submission.
References
Add references/links to any related issues or PRs. These may include:
Issue / context
During the Angular 15 upgrade, @Atmire-Kristof noticed conflicts between the newer versions of the following libraries:
ng-bootstrap@ng-dynamic-forms@ng-dynamic-forms/ui-ng-bootstrapstill requiresng-bootstrapv11 as a peer dependency, which itself doesn't support Angular 15ng-bootstrapversions, so this is not a viable workaroundRather than do a half-upgrade we opted to leave both of these libraries as-is for now. This leads to peer dependency mismatch warnings, but everything remains functional.
Solution
It looks like development of
@ng-dynamic-formshas slowed down as of late, and this version mismatch is a bit of a red flag. Therefore, we should consider moving away from this library and use the default Angular forms instead for more stability.This would involve a significant refactor of DSpace Angular submission.
References
Add references/links to any related issues or PRs. These may include:
Related to [Submission Refactor] Refactor Entity Relationships to be modified via WorkspaceItem #858
Left out of Angular 15 upgrade #2204