Skip to content

Commit 96170c5

Browse files
committed
Address additional lint issues
- the prealloc warning in internal/bridge/crunchybridgecluster/watches.go doesn't occur in 5.8+ so it wasn't handled previously - the gosec conversion issue in internal/controller/postgrescluster/instance.go is handled similarly in 5.8. This slice should always be small.
1 parent 0a96693 commit 96170c5

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

internal/bridge/crunchybridgecluster/watches.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ func (r *CrunchyBridgeClusterReconciler) Watch() handler.EventHandler {
8787
log.Error(err, "Error listing CrunchyBridgeClusters.")
8888
}
8989

90-
reconcileRequests := []reconcile.Request{}
90+
reconcileRequests := make([]reconcile.Request, 0, len(crunchyBridgeClusterList.Items))
9191
for index := range crunchyBridgeClusterList.Items {
9292
reconcileRequests = append(reconcileRequests,
9393
reconcile.Request{

internal/controller/postgrescluster/instance.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -336,6 +336,7 @@ func (r *Reconciler) observeInstances(
336336
status.DesiredPGDataVolume = make(map[string]string)
337337

338338
for _, instance := range observed.bySet[name] {
339+
//nolint:gosec // This slice is always small.
339340
status.Replicas += int32(len(instance.Pods))
340341

341342
if ready, known := instance.IsReady(); known && ready {

0 commit comments

Comments
 (0)