Additional tests

Author: benjaminjb

internal/testing/validation/pgbouncer_test.go

@@ -53,7 +53,7 @@ func TestV1PGBouncerLogging(t *testing.T) {
 			}
 		}`)
 		assert.NilError(t, cc.Create(ctx, base.DeepCopy(), client.DryRunAll),
-			"expected this base to be valid")
+			"expected this option to be valid")
 	})
 
 	t.Run("Cannot set logging on tmp without .log", func(t *testing.T) {
@@ -73,4 +73,96 @@ func TestV1PGBouncerLogging(t *testing.T) {
 		assert.Assert(t, apierrors.IsInvalid(err))
 		assert.ErrorContains(t, err, "logfile config must end with '.log'")
 	})
+
+	t.Run("Cannot set logging on tmp without correct subdir", func(t *testing.T) {
+		tmp := base.DeepCopy()
+
+		require.UnmarshalInto(t, &tmp.Spec.Proxy, `{
+			pgBouncer: {
+				config: {
+					global: {
+						logfile: "/tmp/logs/log.log"
+					}
+				}
+			}
+		}`)
+
+		err := cc.Create(ctx, tmp.DeepCopy(), client.DryRunAll)
+		assert.Assert(t, apierrors.IsInvalid(err))
+		assert.ErrorContains(t, err, "logfile destination is restricted to '/tmp/logs/pgbouncer/' or an existing additional volume")
+
+		require.UnmarshalInto(t, &tmp.Spec.Proxy, `{
+			pgBouncer: {
+				config: {
+					global: {
+						logfile: "/tmp/pgbouncer/log.log"
+					}
+				}
+			}
+		}`)
+
+		err = cc.Create(ctx, tmp.DeepCopy(), client.DryRunAll)
+		assert.Assert(t, apierrors.IsInvalid(err))
+		assert.ErrorContains(t, err, "logfile destination is restricted to '/tmp/logs/pgbouncer/' or an existing additional volume")
+	})
+
+	t.Run("Cannot set logging on volumes that don't exist", func(t *testing.T) {
+		vol := base.DeepCopy()
+
+		require.UnmarshalInto(t, &vol.Spec.Proxy, `{
+			pgBouncer: {
+				config: {
+					global: {
+						logfile: "/volumes/logging/log.log"
+					}
+				}
+			}
+		}`)
+
+		err := cc.Create(ctx, vol.DeepCopy(), client.DryRunAll)
+		assert.Assert(t, apierrors.IsInvalid(err))
+		assert.ErrorContains(t, err, "logfile destination is restricted to '/tmp/logs/pgbouncer/' or an existing additional volume")
+	})
+
+	t.Run("Cannot set logging elsewhere", func(t *testing.T) {
+		vol := base.DeepCopy()
+
+		require.UnmarshalInto(t, &vol.Spec.Proxy, `{
+			pgBouncer: {
+				config: {
+					global: {
+						logfile: "/var/log.log"
+					}
+				}
+			}
+		}`)
+
+		err := cc.Create(ctx, vol.DeepCopy(), client.DryRunAll)
+		assert.Assert(t, apierrors.IsInvalid(err))
+		assert.ErrorContains(t, err, "logfile destination is restricted to '/tmp/logs/pgbouncer/' or an existing additional volume")
+	})
+
+	t.Run("Can set logging on volumes that exist", func(t *testing.T) {
+		vol := base.DeepCopy()
+
+		require.UnmarshalInto(t, &vol.Spec.Proxy, `{
+			pgBouncer: {
+				config: {
+					global: {
+						logfile: "/volumes/logging/log.log"
+					}
+				},
+				volumes: {
+    				additional: [
+					{
+						name: logging,
+        				claimName: required-1
+					}]
+				}
+			}
+		}`)
+
+		assert.NilError(t, cc.Create(ctx, vol.DeepCopy(), client.DryRunAll),
+			"expected this option to be valid")
+	})
 }