REL_5_8 Backpatch: Address prealloc lint issues

Does not include the update to internal/util/volumes.go due to
differences in code.

Issue: PGO-2844

Author: tjmoore4

internal/controller/postgrescluster/cluster.go

@@ -403,10 +403,12 @@ func (r *Reconciler) reconcileDataSource(ctx context.Context,
 	var configs []string
 	switch {
 	case dataSource != nil:
-		configs = []string{dataSource.ClusterName, dataSource.RepoName}
+		configs = make([]string, 0, 2+len(dataSource.Options))
+		configs = append(configs, dataSource.ClusterName, dataSource.RepoName)
 		configs = append(configs, dataSource.Options...)
 	case cloudDataSource != nil:
-		configs = []string{cloudDataSource.Stanza, cloudDataSource.Repo.Name}
+		configs = make([]string, 0, 2+len(cloudDataSource.Options))
+		configs = append(configs, cloudDataSource.Stanza, cloudDataSource.Repo.Name)
 		configs = append(configs, cloudDataSource.Options...)
 	}
 	configHash, err := hashFunc(configs)

internal/controller/postgrescluster/instance.go

@@ -978,7 +978,11 @@ func (r *Reconciler) scaleDownInstances(
 	}
 
 	// grab all pods for the cluster using the observed instances
-	pods := []corev1.Pod{}
+	var podCount int
+	for i := range observedInstances.forCluster {
+		podCount += len(observedInstances.forCluster[i].Pods)
+	}
+	pods := make([]corev1.Pod, 0, podCount)
 	for instanceIndex := range observedInstances.forCluster {
 		for podIndex := range observedInstances.forCluster[instanceIndex].Pods {
 			pods = append(pods, *observedInstances.forCluster[instanceIndex].Pods[podIndex])
@@ -1030,7 +1034,8 @@ func podsToKeep(instances []corev1.Pod, want map[string]int) []corev1.Pod {
 		return keep
 	}
 
-	keepPodList := []corev1.Pod{}
+	// preallocate with the total number of instance Pods
+	keepPodList := make([]corev1.Pod, 0, len(instances))
 	for name, num := range want {
 		list := []corev1.Pod{}
 		for _, instance := range instances {

internal/controller/standalone_pgadmin/configmap.go

@@ -199,7 +199,7 @@ func generateClusterConfig(
 	// which we can do by
 	// a) sorting the ServerGroup name used as a key; and
 	// b) sorting the clusters by name;
-	keys := []string{}
+	keys := make([]string, 0, len(clusters))
 	for key := range clusters {
 		keys = append(keys, key)
 	}

internal/pgbouncer/config.go

@@ -192,19 +192,20 @@ func podConfigFiles(
 	// Start with an empty file at /etc/pgbouncer/pgbouncer.ini. This file can
 	// be overridden by the user, but it must exist because our configuration
 	// file refers to it.
-	projections := []corev1.VolumeProjection{
-		{
-			ConfigMap: &corev1.ConfigMapProjection{
-				LocalObjectReference: corev1.LocalObjectReference{
-					Name: configmap.Name,
-				},
-				Items: []corev1.KeyToPath{{
-					Key:  emptyConfigMapKey,
-					Path: emptyFileProjectionPath,
-				}},
+	// Preallocate: 3 (empty ini file + configmap projection + secret projection)
+	// plus the number of specified files, len(config.Files)
+	projections := make([]corev1.VolumeProjection, 0, 3+len(config.Files))
+	projections = append(projections, corev1.VolumeProjection{
+		ConfigMap: &corev1.ConfigMapProjection{
+			LocalObjectReference: corev1.LocalObjectReference{
+				Name: configmap.Name,
 			},
+			Items: []corev1.KeyToPath{{
+				Key:  emptyConfigMapKey,
+				Path: emptyFileProjectionPath,
+			}},
 		},
-	}
+	})
 
 	// Add any specified projections. These may override the files above.
 	// - https://docs.k8s.io/concepts/storage/volumes/#projected

internal/postgres/exec.go

@@ -74,7 +74,11 @@ func (exec Executor) ExecInDatabasesFromQuery(
 	// database is passed via standard input while the database query is passed
 	// as the first argument. Remaining arguments are passed through to `psql`.
 	stdin := strings.NewReader(sql)
-	args := []string{databases}
+
+	// Using make to preallocate args (using 1 (databases) + len(variables)) triggered
+	// a CodeQL scanning error that a potentially large value might cause an overflow.
+	// To address this, don't preallocate args and have the linter ignore this line.
+	args := []string{databases} //nolint:prealloc
 	for k, v := range variables {
 		args = append(args, "--set="+k+"="+v)
 	}