Skip to content

Commit 329d872

Browse files
Cleanup unused setting
1 parent e972c6a commit 329d872

5 files changed

Lines changed: 72 additions & 65 deletions

File tree

lib/app/app.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import 'package:bible_side/ui/views/search/search_view.dart';
1414
import 'package:bible_side/ui/views/navigation_bible_divisions/navigation_bible_divisions_view.dart';
1515
import 'package:bible_side/ui/views/navigation_books/navigation_books_view.dart';
1616
import 'package:bible_side/ui/views/navigation_sections_chapters/navigation_sections_chapters_view.dart';
17+
import 'package:bible_side/ui/views/bookmarks/bookmarks_view.dart';
1718
// @stacked-import
1819

1920
@StackedApp(
@@ -26,6 +27,7 @@ import 'package:bible_side/ui/views/navigation_sections_chapters/navigation_sect
2627
MaterialRoute(page: NavigationBibleDivisionsView),
2728
MaterialRoute(page: NavigationBooksView),
2829
MaterialRoute(page: NavigationSectionsChaptersView),
30+
MaterialRoute(page: BookmarksView),
2931
// @stacked-route
3032
],
3133
dependencies: [

lib/app/app.router.dart

Lines changed: 70 additions & 36 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/services/settings_service.dart

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import '../common/enums.dart';
66
class SettingsService with ListenableServiceMixin {
77
SettingsService() {
88
listenToReactiveValues([
9-
_isDarkTheme,
109
_showSecondaryArea,
1110
_primaryAreaBible,
1211
_secondaryAreaBible,
@@ -19,7 +18,6 @@ class SettingsService with ListenableServiceMixin {
1918
}
2019

2120
// Interface
22-
static const _kIsDarkTheme = 'IS_DARK_THEME';
2321
static const _kShowSecondaryArea = 'SHOW_SECONDARY_AREA';
2422

2523
// Bibles
@@ -39,8 +37,6 @@ class SettingsService with ListenableServiceMixin {
3937
static const _kShowChaptersAndVerses = 'SHOW_CHAPTERS_AND_VERSES';
4038
static const _kLinkReaderAreaScrolling = 'LINK_READER_AREA_SCROLLING';
4139

42-
bool _isDarkTheme = false;
43-
bool get isDarkTheme => _isDarkTheme;
4440
bool _showSecondaryArea = true;
4541
bool get showSecondaryArea => _showSecondaryArea;
4642

@@ -70,7 +66,6 @@ class SettingsService with ListenableServiceMixin {
7066
bool get linkReaderAreaScrolling => _linkReaderAreaScrolling;
7167

7268
Future<void> initilize() async {
73-
_isDarkTheme = await getIsDarkTheme();
7469
_showSecondaryArea = await getShowSecondaryArea();
7570
_primaryAreaBible = await getPrimaryAreaBible();
7671
_secondaryAreaBible = await getSecondaryAreaBible();
@@ -84,7 +79,6 @@ class SettingsService with ListenableServiceMixin {
8479
_showChaptersAndVerses = await getShowChaptersAndVerses();
8580
_linkReaderAreaScrolling = await getLinkReaderAreaScrolling();
8681

87-
await setIsDarkTheme(_isDarkTheme);
8882
await setShowSecondaryArea(_showSecondaryArea);
8983
await setPrimaryAreaBible(_primaryAreaBible);
9084
await setSecondaryAreaBible(_secondaryAreaBible);
@@ -99,20 +93,6 @@ class SettingsService with ListenableServiceMixin {
9993
await setLinkReaderAreaScrolling(_linkReaderAreaScrolling);
10094
}
10195

102-
// Is dark theme
103-
Future<void> setIsDarkTheme(bool value) async {
104-
_isDarkTheme = value;
105-
SharedPreferences prefs = await SharedPreferences.getInstance();
106-
prefs.setBool(_kIsDarkTheme, value);
107-
notifyListeners();
108-
}
109-
110-
Future<bool> getIsDarkTheme() async {
111-
SharedPreferences prefs = await SharedPreferences.getInstance();
112-
_isDarkTheme = prefs.getBool(_kIsDarkTheme) ?? false;
113-
return _isDarkTheme;
114-
}
115-
11696
// Show secondary area
11797
Future<void> setShowSecondaryArea(bool value) async {
11898
_showSecondaryArea = value;

lib/ui/views/settings/settings_view.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,6 @@ class SettingsView extends StackedView<SettingsViewModel> {
248248
theme: CurrentTheme.light,
249249
onTap: () {
250250
var themeManger = getThemeManager(context);
251-
viewModel.setIsDarkTheme(false);
252251
themeManger.selectThemeAtIndex(0);
253252
},
254253
),
@@ -258,7 +257,6 @@ class SettingsView extends StackedView<SettingsViewModel> {
258257
theme: CurrentTheme.dark,
259258
onTap: () {
260259
var themeManger = getThemeManager(context);
261-
viewModel.setIsDarkTheme(true);
262260
themeManger.selectThemeAtIndex(1);
263261
},
264262
),

0 commit comments

Comments
 (0)