Skip to content

Commit 128ac69

Browse files
Fix bookmarking first verse of chapter or section
1 parent f7c0cf5 commit 128ac69

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

lib/models/bibles/oet_lv_bible.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,11 +105,11 @@ class OETLiteralBibleImpl extends JsonToBible {
105105
if (isSection == true && isNext == true) {
106106
String verseId = '${readerArea.name}-$bookCode-$chapterNumber-$sectionVerseReference';
107107
String bookmarkIcon = bookmarkIconHTML(verseId, bookmarks);
108-
htmlText += """<p ondblclick=onCreateBookmark("$verseId") class="p">
108+
htmlText += """<p>
109109
<div class="section-box">
110110
<p><sup id="$verseId">$chapterNumber:$sectionVerseReference</sup> ${sectionText.replaceAll("'", "’")}</p>
111111
</div>
112-
<span>
112+
<span ondblclick=onCreateBookmark("$verseId") class="p">
113113
$chapterNumberHtml$bookmarkIcon<sup>$sectionVerseReference</sup> ${verseText.replaceAll("'", "’")}
114114
</span>
115115
""";

lib/models/bibles/oet_rv_bible.dart

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import 'dart:developer';
2+
13
import '../../common/enums.dart';
24
import '../json_to_bible.dart';
35

@@ -19,7 +21,6 @@ class OETReadersBibleImpl extends JsonToBible {
1921

2022
for (Map<String, dynamic> chapter in chaptersData) {
2123
chapterNumber = chapter['chapterNumber'];
22-
2324
chapterNumberHtml = '<span class="c" id="${readerArea.name}-$bookCode-$chapterNumber">$chapterNumber</span>';
2425

2526
chapterContents = chapter['contents'];
@@ -104,11 +105,11 @@ class OETReadersBibleImpl extends JsonToBible {
104105
if (isSection == true && isNext == true) {
105106
String verseId = '${readerArea.name}-$bookCode-$chapterNumber-$sectionVerseReference';
106107
String bookmarkIcon = bookmarkIconHTML(verseId, bookmarks);
107-
htmlText += """<p ondblclick=onCreateBookmark("$verseId") class="p">
108+
htmlText += """<p>
108109
<div class="section-box">
109110
<p><sup id="$verseId">$chapterNumber:$sectionVerseReference</sup> ${sectionText.replaceAll("'", "’")}</p>
110111
</div>
111-
<span>
112+
<span ondblclick=onCreateBookmark("$verseId") class="p">
112113
$chapterNumberHtml$bookmarkIcon<sup>$sectionVerseReference</sup> ${verseText.replaceAll("'", "’")}
113114
</span>
114115
""";
@@ -122,6 +123,7 @@ class OETReadersBibleImpl extends JsonToBible {
122123
}
123124
}
124125
}
126+
//log(htmlText);
125127
return htmlText;
126128
}
127129
}

0 commit comments

Comments
 (0)