diff --git a/.jules/bolt.md b/.jules/bolt.md index f1a8c1466..916ff9401 100644 --- a/.jules/bolt.md +++ b/.jules/bolt.md @@ -77,3 +77,7 @@ Optimized metric route processing to O(N) by creating a mapping of routes direct ## 2024-07-13 - [Optimize Export Dictionary FK lookups] **Learning:** Found O(N * C * E) performance bottleneck in ERD export dictionaries due to repeated array searching with `edges.some()` inside a nested loop over nodes and columns. **Action:** Replace repeated linear array scans for edges by precomputing O(1) Set lookups of foreign key column handles per node before looping. + +## 2026-08-25 - [Avoid Array.from intermediate allocations in React hot paths] +**Learning:** Using `Array.from(string).join('-')` inside highly-invoked code paths like handle generation for ERD tables creates an intermediate array allocation for every column per node, causing significant garbage collection pressure during large graph renders. +**Action:** Replace `Array.from` with a simple string concatenation inside a `for...of` loop for hot paths to prevent intermediate array allocations and reduce GC overhead. diff --git a/frontend/src/erd/handleUtils.ts b/frontend/src/erd/handleUtils.ts index 054d5ab2a..24094c345 100644 --- a/frontend/src/erd/handleUtils.ts +++ b/frontend/src/erd/handleUtils.ts @@ -1,8 +1,16 @@ export function sanitizeHandleId(columnName: string): string { - const encoded = Array.from(columnName, (char) => { - // Array.from only yields non-empty Unicode scalars, so codePointAt(0) is defined. - return char.codePointAt(0)!.toString(16).padStart(4, '0') - }).join('-') + // ⚡ Bolt: Use a for...of loop instead of Array.from(columnName).join('-') + // to avoid allocating an intermediate array and reduce GC pressure for hot paths. + let encoded = '' + let isFirst = true + for (const char of columnName) { + if (!isFirst) { + encoded += '-' + } + // for...of over strings natively yields non-empty Unicode scalars, so codePointAt(0) is always defined. + encoded += char.codePointAt(0)!.toString(16).padStart(4, '0') + isFirst = false + } return `c-${encoded || 'empty'}` }