From be5d2a555ee6322b02368cdb9c373e11dcffafc3 Mon Sep 17 00:00:00 2001
From: seonghobae <8172694+seonghobae@users.noreply.github.com>
Date: Mon, 10 Aug 2026 04:20:13 +0000
Subject: [PATCH] =?UTF-8?q?=F0=9F=9B=A1=EF=B8=8F=20Sentinel:=20[MEDIUM]=20?=
 =?UTF-8?q?Fix=20unvalidated=20input=20on=20exported=20functions?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Added explicit input validation for type, length, and bounds at the beginning of vuongtest and icci to fail securely with call. = FALSE.
---
 .jules/sentinel.md | 4 ++++
 R/icci.R           | 4 ++++
 R/vuongtest.R      | 7 +++++++
 3 files changed, 15 insertions(+)

diff --git a/.jules/sentinel.md b/.jules/sentinel.md
index bc5c6e1..4773d91 100644
--- a/.jules/sentinel.md
+++ b/.jules/sentinel.md
@@ -12,3 +12,7 @@
 **Vulnerability:** Raw `stop()` and `warning()` calls without `call. = FALSE` in `llcont.R` and `vuongtest.R` exposed execution stack/call details when raised.
 **Learning:** While some instances of `stop()` inside `tryCatch()` were previously fixed to hide the call stack, other standalone exceptions and warnings still leaked call context. Security must be consistently applied across the entire codebase.
 **Prevention:** Always set `call. = FALSE` when using `stop()` or `warning()` to enforce a secure-by-default boundary and prevent internal execution paths from being disclosed to the end user.
+## 2024-08-10 - Fix Information Disclosure via Unvalidated Arguments
+**Vulnerability:** Exported functions like vuongtest and icci lacked input validation for arguments like `nested`, `adj`, and `conf.level`, allowing invalid types to trigger raw R errors deep inside internal logic.
+**Learning:** Unvalidated inputs passed to exported functions can bypass top-level `stop` with `call. = FALSE` safeguards, exposing internal execution contexts and call stacks when evaluated.
+**Prevention:** Always strictly validate the type, length, and bounds of user inputs at the very beginning of exported functions to fail securely.
diff --git a/R/icci.R b/R/icci.R
index f22278a..a38c1af 100644
--- a/R/icci.R
+++ b/R/icci.R
@@ -65,6 +65,10 @@
 #' @export
 icci <- function(object1, object2, conf.level=.95, ll1=llcont, ll2=llcont) {
 
+  if (!is.numeric(conf.level) || length(conf.level) != 1 || is.na(conf.level) || conf.level <= 0 || conf.level >= 1) {
+    stop("'conf.level' must be a single number between 0 and 1.", call. = FALSE)
+  }
+
   ## check objects, issue warnings/errors, get classes/calls
   obinfo <- check.obj(object1, object2)
   callA <- obinfo$callA; classA <- obinfo$classA
diff --git a/R/vuongtest.R b/R/vuongtest.R
index 2bdfbf6..dd6bf82 100644
--- a/R/vuongtest.R
+++ b/R/vuongtest.R
@@ -98,6 +98,13 @@
 #' @export
 vuongtest <- function(object1, object2, nested=FALSE, adj="none", ll1=llcont, ll2=llcont, score1=NULL, score2=NULL, vc1=vcov, vc2=vcov) {
 
+  if (!is.logical(nested) || length(nested) != 1 || is.na(nested)) {
+    stop("'nested' must be a single logical value.", call. = FALSE)
+  }
+  if (!is.character(adj) || length(adj) != 1 || !(adj %in% c("none", "aic", "bic"))) {
+    stop("'adj' must be 'none', 'aic', or 'bic'.", call. = FALSE)
+  }
+
   ## check objects, issue warnings/errors, get classes/calls
   obinfo <- check.obj(object1, object2)
   callA <- obinfo$callA; classA <- obinfo$classA