Commit 89044cb
committed
Fix authselect remediation with multiple features
The ansible_authselect_force_reselect and bash_authselect_force_reselect
macros were using unquoted command substitution which triggered SC2046
shellcheck warnings about word splitting.
The issue was that "authselect current --raw" returns a profile with
features as separate words (e.g., "sssd with-faillock with-fingerprint"),
and intentional word splitting is required for authselect to properly
parse the profile name and features as separate arguments.
Fixed by using proper word splitting patterns:
- Bash: Use read -ra to safely split into array, then expand with "@"
- Ansible: Split into two tasks - capture output, then expand variable
This resolves shellcheck SC2046 warnings while maintaining correct
functionality for profiles with multiple features.
Fixes: #146001 parent e7e8a8c commit 89044cb
6 files changed
Lines changed: 60 additions & 3 deletions
File tree
- linux_os/guide/system/accounts/accounts-pam/locking_out_password_attempts/account_password_pam_faillock_password_auth/tests
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
930 | 930 | | |
931 | 931 | | |
932 | 932 | | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
| 938 | + | |
933 | 939 | | |
934 | | - | |
935 | | - | |
| 940 | + | |
| 941 | + | |
936 | 942 | | |
937 | 943 | | |
938 | 944 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2484 | 2484 | | |
2485 | 2485 | | |
2486 | 2486 | | |
2487 | | - | |
| 2487 | + | |
| 2488 | + | |
2488 | 2489 | | |
2489 | 2490 | | |
2490 | 2491 | | |
| |||
0 commit comments