Handle older Restic and harden workflow progress recovery

Author: Commanderx-code

.github/workflows/linux-packages.yml

@@ -25,6 +25,13 @@ jobs:
           components: clippy
       - name: Install build and smoke-test dependencies
         run: sudo apt-get update && sudo apt-get install -y libwebkit2gtk-4.1-dev build-essential libssl-dev libayatana-appindicator3-dev librsvg2-dev patchelf restic rpm libarchive-tools xvfb dbus-x11 libnotify-bin
+      - name: Install checksum-pinned Restic for restore integration tests
+        run: |
+          curl -fsSL https://github.com/restic/restic/releases/download/v0.19.1/restic_0.19.1_linux_amd64.bz2 -o /tmp/restic-ci.bz2
+          echo 'f415415624dcc452f2a02b8c33641791a8c6d6d3b65bbb3543fcf9a25151585c  /tmp/restic-ci.bz2' | sha256sum -c -
+          bzip2 -dk /tmp/restic-ci.bz2
+          sudo install -m755 /tmp/restic-ci /usr/local/bin/restic
+          restic version
       - run: npm ci
       - run: npm run check && npm test && npm run test:rust
       - run: cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets -- -D warnings
@@ -44,7 +51,7 @@ jobs:
     timeout-minutes: 35
     steps:
       - name: Install tools
-        run: dnf install -y git nodejs npm rust cargo gcc gcc-c++ pkgconf-pkg-config openssl-devel webkit2gtk4.1-devel libappindicator-gtk3-devel librsvg2-devel rpm-build python3 binutils libarchive xorg-x11-server-Xvfb xorg-x11-xauth dbus-daemon shadow-utils libnotify
+        run: dnf install -y git nodejs npm rust cargo gcc gcc-c++ pkgconf-pkg-config openssl-devel webkit2gtk4.1-devel libappindicator-gtk3-devel librsvg2-devel rpm-build python3 binutils bsdtar xorg-x11-server-Xvfb xorg-x11-xauth dbus-daemon shadow-utils libnotify restic
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:

docs/installation.md

@@ -79,3 +79,5 @@ The browser preview uses sample repositories and configurations. It cannot run G
 After installation, open **Settings → System integrations**. Command Center can detect an existing dotfiles machine configuration, backup helpers, and Ghostty/Fastfetch source paths. Review the detected paths and save your settings.
 
 Git, Home Manager, Restic, Ghostty, Fastfetch, and backup helpers are used when installed and configured. They are not all required to open the app. See the [user guide](user-guide.md#connect-your-setup) for each integration.
+
+File restores require **Restic 0.17 or newer** for its no-overwrite protection; Command Center checks support before preparing a restore. Some distributions ship an older Restic independently of Command Center.

docs/release-notes.md

@@ -15,7 +15,7 @@ Git file diffs, branches, stashes, branch publishing, service controls and audit
 
 ### Linux downloads
 
-The `.deb` and `.rpm` assets target **x86_64** and require **glibc 2.39+, GTK 3, WebKitGTK 4.1, and the platform's AppIndicator library**. Notifications additionally use `notify-send`. Install your downloaded package with `sudo apt install ./command-center_0.4.0_amd64.deb` or `sudo dnf install ./command-center-0.4.0-1.x86_64.rpm` on a compatible distribution.
+The `.deb` and `.rpm` assets target **x86_64** and require **glibc 2.39+, GTK 3, WebKitGTK 4.1, and the platform's AppIndicator library**. Notifications additionally use `notify-send`. File restores require Restic 0.17+; older versions receive a compatibility error before a restore starts. Install your downloaded package with `sudo apt install ./command-center_0.4.0_amd64.deb` or `sudo dnf install ./command-center-0.4.0-1.x86_64.rpm` on a compatible distribution.
 
 Download `SHA256SUMS` beside the package and run `sha256sum --check --ignore-missing SHA256SUMS`.
 

packaging/aur/PKGBUILD

@@ -17,7 +17,7 @@ prepare() {
 }
 build() {
   cd "$srcdir/command-center"
-  npm run desktop:build -- --locked
+  npm run desktop:build -- -- --locked
 }
 package() {
   cd "$srcdir/command-center"

src-tauri/src/integrations.rs

@@ -378,6 +378,10 @@ pub fn build_plan(r: &Request, s: &Settings) -> Result<Plan, String> {
                 plan.explanation = "Check repository structure and metadata. This does not perform a full read of every data block.".into();
             }
             "restore" => {
+                let (ok, help, error) = p::output(Command::new("restic").args(["restore", "--help"]), 15)?;
+                if !ok || !help.contains("--overwrite") || !help.contains("--verify") {
+                    return Err(format!("File restore requires Restic 0.17 or newer with --overwrite and --verify support. Update Restic before restoring. {error}"));
+                }
                 snapshot_id(&r.snapshot)?;
                 let target = p::expand(&r.target)?;
                 validate_restore_target(&target)?;

src/operations-model.js

@@ -95,3 +95,33 @@ export function timelineFilter(rows, query, category) {
       ),
   );
 }
+
+export function restoreRun(value) {
+  if (
+    !value ||
+    typeof value.name !== "string" ||
+    !Array.isArray(value.rows) ||
+    !value.rows.length ||
+    value.rows.length > 30 ||
+    !Number.isInteger(value.index) ||
+    value.index < 0 ||
+    value.index > value.rows.length ||
+    value.rows.some(
+      (row) =>
+        typeof row.name !== "string" ||
+        typeof row.status !== "string" ||
+        !row.request ||
+        !stepTypes[row.request.action],
+    )
+  )
+    return null;
+  if (value.index === value.rows.length && value.status !== "succeeded")
+    return null;
+  return {
+    ...value,
+    jobId: null,
+    status: ["succeeded", "stopped"].includes(value.status)
+      ? value.status
+      : "interrupted",
+  };
+}

src/operations.js

@@ -4,6 +4,7 @@ import {
   stepTypes,
   toolFolderItems,
   advanceRun,
+  restoreRun,
   timelineFilter,
 } from "./operations-model.js";
 export function createOperations({
@@ -69,13 +70,9 @@ export function createOperations({
     }
   };
   try {
-    current = JSON.parse(
-      localStorage.getItem("command-center-workflow-run") || "null",
+    current = restoreRun(
+      JSON.parse(localStorage.getItem("command-center-workflow-run") || "null"),
     );
-    if (current && !["succeeded", "stopped"].includes(current.status)) {
-      current.status = "interrupted";
-      current.jobId = null;
-    }
   } catch {
     current = null;
   }
@@ -677,12 +674,14 @@ export function createOperations({
   $("#notification-form").addEventListener("submit", async (ev) => {
     ev.preventDefault();
     try {
+      const preferences = {};
+      for (const key of ["enabled", "failures", "completions", "health"])
+        preferences[key] = $("#notice-" + key).checked;
+      preferences.quietStart = Number($("#notice-start").value);
+      preferences.quietEnd = Number($("#notice-end").value);
       await ensure();
       const next = structuredClone(collection);
-      for (const key of ["enabled", "failures", "completions", "health"])
-        next.notifications[key] = $("#notice-" + key).checked;
-      next.notifications.quietStart = Number($("#notice-start").value);
-      next.notifications.quietEnd = Number($("#notice-end").value);
+      next.notifications = preferences;
       await save(next);
       $("#notice-status").textContent = "Notification preferences saved.";
     } catch (err) {

src/styles.css

@@ -2,6 +2,7 @@ import test from "node:test";
 import assert from "node:assert/strict";
 import {
   advanceRun,
+  restoreRun,
   toolFolderItems,
   timelineFilter,
   weeklyRecipe,
@@ -75,3 +76,19 @@ test("starter workflow checks readiness before backup and contains no unattended
     ["backup-ready", "backup", "restic-check", "health-check"],
   );
 });
+
+test("corrupted progress is ignored and unfinished work never resumes automatically", () => {
+  assert.equal(restoreRun({ name: "Broken", rows: [], index: 0 }), null);
+  assert.equal(restoreRun({ name: "Broken", rows: [{}], index: 0 }), null);
+  const restored = restoreRun({
+    name: "Backup",
+    index: 0,
+    status: "running",
+    jobId: "old",
+    rows: [
+      { name: "Backup", request: { action: "backup" }, status: "running" },
+    ],
+  });
+  assert.equal(restored.status, "interrupted");
+  assert.equal(restored.jobId, null);
+});