feat: add easy code standard (#353)

* feat: add easy code standard

* style: apply easy code standard

* style: add new php cs fixer rules

* style: apply new php cs fixer rules

* style: apply new php cs fixer rules

Author: rgomezcasas

.php-cs-fixer.dist.php

@@ -49,7 +49,7 @@ static-analysis: composer-env-file
 
 .PHONY: lint
 lint:
-	docker exec codely-php_ddd_skeleton-mooc_backend-php ./vendor/bin/php-cs-fixer fix --config .php-cs-fixer.dist.php --allow-risky=yes --dry-run
+	docker exec codely-php_ddd_skeleton-mooc_backend-php ./vendor/bin/ecs check
 
 .PHONY: run-tests
 run-tests: composer-env-file

Makefile

@@ -1,7 +1,9 @@
 <?php
 
+declare(strict_types=1);
+
 return [
-    Symfony\Bundle\FrameworkBundle\FrameworkBundle::class                              => ['all' => true],
+    Symfony\Bundle\FrameworkBundle\FrameworkBundle::class => ['all' => true],
     FriendsOfBehat\SymfonyExtension\Bundle\FriendsOfBehatSymfonyExtensionBundle::class => ['test' => true],
     //    WouterJ\EloquentBundle\WouterJEloquentBundle::class                                => ['test' => true]
 ];

apps/backoffice/backend/config/bundles.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use CodelyTv\Apps\Backoffice\Backend\BackofficeBackendKernel;
 use Symfony\Component\ErrorHandler\Debug;
 use Symfony\Component\HttpFoundation\Request;
@@ -23,8 +25,8 @@
     Request::setTrustedHosts([$trustedHosts]);
 }
 
-$kernel   = new BackofficeBackendKernel($_SERVER['APP_ENV'], (bool) $_SERVER['APP_DEBUG']);
-$request  = Request::createFromGlobals();
+$kernel = new BackofficeBackendKernel($_SERVER['APP_ENV'], (bool) $_SERVER['APP_DEBUG']);
+$request = Request::createFromGlobals();
 $response = $kernel->handle($request);
 $response->send();
 $kernel->terminate($request, $response);

apps/backoffice/backend/public/index.php

@@ -12,7 +12,7 @@
 
 use function dirname;
 
-final class BackofficeBackendKernel extends Kernel
+class BackofficeBackendKernel extends Kernel
 {
     use MicroKernelTrait;
 

apps/backoffice/backend/src/BackofficeBackendKernel.php

@@ -15,33 +15,31 @@
 
 final readonly class CoursesGetController
 {
-    public function __construct(private QueryBus $queryBus)
-    {
-    }
+    public function __construct(private QueryBus $queryBus) {}
 
     public function __invoke(Request $request): JsonResponse
     {
         $orderBy = $request->query->get('order_by');
         $order = $request->query->get('order');
-        $limit  = $request->query->get('limit');
+        $limit = $request->query->get('limit');
         $offset = $request->query->get('offset');
 
         /** @var BackofficeCoursesResponse $response */
         $response = $this->queryBus->ask(
             new SearchBackofficeCoursesByCriteriaQuery(
                 (array) $request->query->get('filters'),
-                null === $orderBy ? null : (string) $orderBy,
-                null === $order ? null : (string) $order,
-                null === $limit ? null : (int) $limit,
-                null === $offset ? null : (int) $offset
+                $orderBy === null ? null : (string) $orderBy,
+                $order === null ? null : (string) $order,
+                $limit === null ? null : (int) $limit,
+                $offset === null ? null : (int) $offset
             )
         );
 
         return new JsonResponse(
             map(
                 fn (BackofficeCourseResponse $course) => [
-                    'id'       => $course->id(),
-                    'name'     => $course->name(),
+                    'id' => $course->id(),
+                    'name' => $course->name(),
                     'duration' => $course->duration(),
                 ],
                 $response->courses()

apps/backoffice/backend/src/Controller/Courses/CoursesGetController.php

@@ -11,14 +11,12 @@
 
 final readonly class MetricsController
 {
-    public function __construct(private PrometheusMonitor $monitor)
-    {
-    }
+    public function __construct(private PrometheusMonitor $monitor) {}
 
     public function __invoke(Request $request): Response
     {
         $renderer = new RenderTextFormat();
-        $result   = $renderer->render($this->monitor->registry()->getMetricFamilySamples());
+        $result = $renderer->render($this->monitor->registry()->getMetricFamilySamples());
 
         return new Response($result, 200, ['Content-Type' => RenderTextFormat::MIME_TYPE]);
     }

apps/backoffice/backend/src/Controller/Metrics/MetricsController.php

@@ -1,8 +1,10 @@
 <?php
 
+declare(strict_types=1);
+
 return [
-    Symfony\Bundle\FrameworkBundle\FrameworkBundle::class                              => ['all' => true],
+    Symfony\Bundle\FrameworkBundle\FrameworkBundle::class => ['all' => true],
     FriendsOfBehat\SymfonyExtension\Bundle\FriendsOfBehatSymfonyExtensionBundle::class => ['test' => true],
-    Symfony\Bundle\TwigBundle\TwigBundle::class                                        => ['all' => true],
+    Symfony\Bundle\TwigBundle\TwigBundle::class => ['all' => true],
     //    WouterJ\EloquentBundle\WouterJEloquentBundle::class                                => ['test' => true]
 ];

apps/backoffice/frontend/config/bundles.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use CodelyTv\Apps\Backoffice\Frontend\BackofficeFrontendKernel;
 use Symfony\Component\ErrorHandler\Debug;
 use Symfony\Component\HttpFoundation\Request;
@@ -23,8 +25,8 @@
     Request::setTrustedHosts([$trustedHosts]);
 }
 
-$kernel   = new BackofficeFrontendKernel($_SERVER['APP_ENV'], (bool) $_SERVER['APP_DEBUG']);
-$request  = Request::createFromGlobals();
+$kernel = new BackofficeFrontendKernel($_SERVER['APP_ENV'], (bool) $_SERVER['APP_DEBUG']);
+$request = Request::createFromGlobals();
 $response = $kernel->handle($request);
 $response->send();
 $kernel->terminate($request, $response);

apps/backoffice/frontend/public/index.php

@@ -12,7 +12,7 @@
 
 use function dirname;
 
-final class BackofficeFrontendKernel extends Kernel
+class BackofficeFrontendKernel extends Kernel
 {
     use MicroKernelTrait;