Skip to content

Add option to preserve pre-existing HTML sizes attributes on images #1115

Description

@pirate-bot

Impact: 75 · Confidence: 95 · Complexity: 35

Description

Problem

When Optimole processes frontend images, its Page Profiler replaces existing HTML sizes attributes with automatically measured slot dimensions. Site developers who have crafted accurate sizes attributes (e.g. for hero images or complex responsive layouts) find their attributes overwritten. Currently, the only way to prevent Optimole from replacing a sizes attribute is using CSS function workarounds like calc(100vw).

Desired Behavior

Provide an official plugin configuration setting or supported attribute (e.g. data-optml-keep-sizes or a global setting 'Preserve existing sizes attributes') so site administrators can prevent Optimole from overwriting manually defined HTML sizes attributes.

Acceptance Criteria

  • Add a setting in Optimole options or support a specific HTML data attribute to skip sizes attribute replacement.
  • When active/present, Optimole's HTML tag parser leaves existing sizes attributes untouched.
  • Include unit test coverage verifying pre-existing sizes attributes are preserved when the setting or attribute is present.

Customer Context

The customer has hand-crafted sizes attributes on photography listings and hero images. Optimole overwrites these with inaccurate profiler-generated slot measurements. The customer asks for an official setting or supported attribute to preserve existing sizes attributes without relying on calc() workarounds.

Root Cause Analysis

The customer manages an image-centric photography site and encountered multiple issues stemming from Optimole's automated HTML replacement and page profiler logic: 1) Optimole automatically overwrites HTML sizes attributes with measured slot widths unless explicit CSS functions like calc() are detected, leaving site authors who create custom responsive sizes attributes without a supported setting to preserve their HTML markup. 2) Profiled srcset candidate generation applies DPR transformations in a way that causes candidate descriptors to mismatch delivered image intrinsic widths when Retina Quality is active. 3) Page Profiler slot extrapolation calculates incorrect viewport slot widths on mobile layouts. 4) Duplicate max-width conditions are generated in sizes strings. 5) Database queries executed during the output buffer shutdown callback trigger MySQL 'Commands out of sync' errors. While issues #1111-#1114 address the specific bug regressions, an official setting/option to preserve existing sizes attributes fulfills an unaddressed gap in product configuration.

Reasoning

The customer conversation contains 5 distinct filable requests/reports: 1) Request for an official configuration option or mechanism to preserve pre-existing HTML sizes attributes on images rather than having Optimole overwrite them (new_feature_request). 2) Bug report that profiled srcset width descriptors mismatch delivered intrinsic image widths when Retina Quality is enabled, already tracked in GitHub issue #1111 (already_exists_github). 3) Bug report regarding inaccurate responsive slot widths extrapolated by Page Profiler, already tracked in issue #1112 (already_exists_github). 4) Bug report regarding duplicate max-width conditions in generated sizes attributes, already tracked in issue #1113 (already_exists_github). 5) Bug report regarding MySQL 'Commands out of sync' errors caused by PageProfiler transient reads during shutdown, already tracked in issue #1114 (already_exists_github). The top-level decision reflects the new, actionable feature request.


Source: HelpScout #3424946418
Generated by feature-request-triage workflow (ID: feature-request-triage_6a8821dfeacaf1.56068976)

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions