This repository was archived by the owner on Jan 3, 2023. It is now read-only.
part 1 of js/homework#6
Open
anthonythuo2320 wants to merge 1 commit into
Open
Conversation
Happy0
reviewed
Jul 5, 2017
Happy0
left a comment
Happy0
left a comment
There was a problem hiding this comment.
Good work. You've shown a good understanding of manipulating DOM elements and using helper functions / for loops and if statements.
| // 2. Define your event handler (callback <-- function) | ||
| myButton.addEventListener('click', doSomething); | ||
|
|
||
| function doSomething(){ |
There was a problem hiding this comment.
You could rename this function to something describing what it does.
Maybe 'changePageElementColours' or something :P
| function changeFontColor(element, colour) { | ||
| element.style.color = colour; | ||
| } | ||
| function jumbotronColor(element, colour) { |
There was a problem hiding this comment.
You aren't using this function. Maybe you don't need it and it can be removed?
| @@ -0,0 +1,44 @@ | |||
|
|
|||
|
|
|||
| function changeBackgroundColour(element, colour, ) { | |||
There was a problem hiding this comment.
the ',' after colour is not valid javascript. Maybe it breaks your function?
|
|
||
| } | ||
| var myButtons = document.querySelectorAll('.colorButton'); | ||
| for (var i = 0; i < myButtons.length; i++) { |
There was a problem hiding this comment.
Ha :). Nice use of a for loop and if statements in the 'changeColor' function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.