Address review feedback on sprint 5 exercises

Author: RomanSanaye

sprint-5-exercises/enumm.py

@@ -74,14 +74,20 @@ class Laptop:
 
 
 # Convert the user's input into an OperatingSystem enum value.
-# If the value isn't one of our enum choices, exit with an error.
-try:
-    preferred_operating_system = OperatingSystem(
-        input("What is your preferred operating system? ")
-    )
-except ValueError:
-    print("Invalid operating system.", file=sys.stderr)
-    sys.exit(1)
+# If the input is invalid, ask the user to try again.
+while True:
+    try:
+        preferred_operating_system = OperatingSystem(
+            input(
+                "What is your preferred operating system "
+                "(macOS, Arch Linux, or Ubuntu)? "
+            )
+        )
+        break
+    except ValueError:
+        print(
+            "Invalid operating system. " "Please choose macOS, Arch Linux, or Ubuntu."
+        )
 
 
 # Create a Person using the validated input.

sprint-5-exercises/method.py

@@ -11,6 +11,13 @@ def is_adult(self):
         today = date.today()
         age = today.year - self.date_of_birth.year
 
+        # check if ones birthday has happened yet in this year;
+        if (today.month, today.day) < (
+            self.date_of_birth.month,
+            self.date_of_birth.day,
+        ):
+            age -= 1
+
         return age >= 18
 
 

sprint-5-exercises/type-checking-mypy.py

@@ -1,16 +1,16 @@
-def open_account(balances, name, amount):
+def open_account(balances: dict[str, int], name: str, amount: int) -> None:
     balances[name] = amount
 
 
-def sum_balances(accounts):
+def sum_balances(accounts: dict[str, int]) -> int:
     total = 0
     for name, pence in accounts.items():
         print(f"{name} had balance {pence}")
         total += pence
     return total
 
 
-def format_pence_as_string(total_pence):
+def format_pence_as_string(total_pence: int) -> str:
     if total_pence < 100:
         return f"{total_pence}p"
     pounds = int(total_pence / 100)
@@ -24,8 +24,8 @@ def format_pence_as_string(total_pence):
     "Georg": 831,
 }
 
-open_account(balances, "Tobi", 9.13)
-open_account(balances, "Olya", "£7.13")
+open_account(balances, "Tobi", 913)
+open_account(balances, "Olya", 713)
 
 total_pence = sum_balances(balances)
 total_string = format_pence_as_string(total_pence)
@@ -39,3 +39,10 @@ def format_pence_as_string(total_pence):
 # type-checking-mypy.py:31: error: Name "format_pence_as_str" is not defined  [name-defined]
 
 # to fix the bug we need to add the positional argument in open account function and call the correct name of the second function. "format_pence_as_string"
+
+# After adding type annotations to the functions and testing with mypy I got the following errors:
+# sprint-5-exercises/type-checking-mypy.py:27: error: Argument 3 to "open_account" has incompatible type "float"; expected "int"  [arg-type].
+# ========> To fix it, we should change the argument type from float to integer.
+
+# sprint-5-exercises/type-checking-mypy.py:28: error: Argument 3 to "open_account" has incompatible type "str"; expected "int"  [arg-type]
+# ==========> to fix this issue we should change the argument type from string to integer.

sprint-5-exercises/type-guided-refactoring.py

@@ -21,14 +21,14 @@ class Laptop:
 def find_possible_laptops(laptops: List[Laptop], person: Person) -> List[Laptop]:
     possible_laptops = []
     for laptop in laptops:
-        if laptop.operating_system == person.preferred_operating_systems:
+        if laptop.operating_system in person.preferred_operating_systems:
             possible_laptops.append(laptop)
     return possible_laptops
 
 
 people = [
-    Person(name="Imran", age=22, preferred_operating_systems="Ubuntu"),
-    Person(name="Eliza", age=34, preferred_operating_systems="Arch Linux"),
+    Person(name="Imran", age=22, preferred_operating_systems=["Ubuntu"]),
+    Person(name="Eliza", age=34, preferred_operating_systems=["Arch Linux"]),
 ]
 
 laptops = [
@@ -65,3 +65,10 @@ def find_possible_laptops(laptops: List[Laptop], person: Person) -> List[Laptop]
 for person in people:
     possible_laptops = find_possible_laptops(laptops, person)
     print(f"Possible laptops for {person.name}: {possible_laptops}")
+
+# After testing with mypy I found 2 errors:
+# sprint-5-exercises/type-guided-refactoring.py:30: error: Argument "preferred_operating_systems" to "Person" has incompatible type "str"; expected "list[str]"  [arg-type].
+# =======> to fix the issue we should have list of string instead of str itself.
+
+# sprint-5-exercises/type-guided-refactoring.py:31: error: Argument "preferred_operating_systems" to "Person" has incompatible type "str"; expected "list[str]"  [arg-type].
+# ========> to fix the issue we should have list of string instead of str itself.