made reviewed changes

Author: Alex-Jamshidi

sprint-5-prep-exercises/exercise_06.py

@@ -1,4 +1,13 @@
 # Think of the advantages of using methods instead of free functions. Write them down in your notebook.
 
 # Better readability of code
-# Encapsulation of that function only to class - cleaner and better security.
+# - Method names can be simplified as they only apply to that class, they are contained within the class which is more
+#   organised and method names can be reused in different classes.
+
+# Encapsulation of that function only to class - cleaner and better security.
+# - This can allow for discoverability of methods when writing code using . in an IDE.
+# - Data can be protected from outside functions changing it, this allows for control over what can be changed using
+#   only the inbuilt methods of a class
+
+# Potential drawback: For a function that may want to be used on class objects from multiple different classes it may
+# be better to use a function instead of repeated a method for each class.

sprint-5-prep-exercises/exercise_07.py

@@ -1,5 +1,6 @@
 from datetime import date
 
+
 class Person:
     def __init__(self, name: str, dob: date, preferred_operating_system: str):
         self.name = name
@@ -9,12 +10,10 @@ def __init__(self, name: str, dob: date, preferred_operating_system: str):
     def is_adult(self):
         dob = self.dob
         today = date.today()
-        if dob.year > today.year - 18: return False
-        if dob.year == today.year - 18:
-            if dob.month > today.month: return False
-            if dob.month == today.month:
-                if dob.day > today.day: return False
-        return True
+        today_tuple = (today.year, today.month, today.day)
+        eighteenth_bday_tuple = (dob.year + 18, dob.month, dob.day)
+
+        return today_tuple >= eighteenth_bday_tuple
 
 
 imran = Person("Imran", date(2004, 8, 31), "Ubuntu")
@@ -23,4 +22,4 @@ def is_adult(self):
 # Change the Person class to take a date of birth
 # (using the standard library’s datetime.date class) and store it in a field instead of age.
 
-# Update the is_adult method to act the same as before.
+# Update the is_adult method to act the same as before.

sprint-5-prep-exercises/exercise_10.py

@@ -1,11 +1,11 @@
 from dataclasses import dataclass
-from typing import List
+
 
 @dataclass(frozen=True)
 class Person:
     name: str
     age: int
-    preferred_operating_systems: List[str]
+    preferred_operating_systems: list[str]
 
 
 @dataclass(frozen=True)
@@ -17,10 +17,10 @@ class Laptop:
     operating_system: str
 
 
-def find_possible_laptops(laptops: List[Laptop], person: Person) -> List[Laptop]:
+def find_possible_laptops(laptops: list[Laptop], person: Person) -> list[Laptop]:
     possible_laptops = []
     for laptop in laptops:
-        if laptop.operating_system == person.preferred_operating_systems:
+        if laptop.operating_system in person.preferred_operating_systems:
             possible_laptops.append(laptop)
     return possible_laptops
 
@@ -31,10 +31,34 @@ def find_possible_laptops(laptops: List[Laptop], person: Person) -> List[Laptop]
 ]
 
 laptops = [
-    Laptop(id=1, manufacturer="Dell", model="XPS", screen_size_in_inches=13, operating_system="Arch Linux"),
-    Laptop(id=2, manufacturer="Dell", model="XPS", screen_size_in_inches=15, operating_system="Ubuntu"),
-    Laptop(id=3, manufacturer="Dell", model="XPS", screen_size_in_inches=15, operating_system="ubuntu"),
-    Laptop(id=4, manufacturer="Apple", model="macBook", screen_size_in_inches=13, operating_system="macOS"),
+    Laptop(
+        id=1,
+        manufacturer="Dell",
+        model="XPS",
+        screen_size_in_inches=13,
+        operating_system="Arch Linux",
+    ),
+    Laptop(
+        id=2,
+        manufacturer="Dell",
+        model="XPS",
+        screen_size_in_inches=15,
+        operating_system="Ubuntu",
+    ),
+    Laptop(
+        id=3,
+        manufacturer="Dell",
+        model="XPS",
+        screen_size_in_inches=15,
+        operating_system="Ubuntu",
+    ),
+    Laptop(
+        id=4,
+        manufacturer="Apple",
+        model="macBook",
+        screen_size_in_inches=13,
+        operating_system="macOS",
+    ),
 ]
 
 for person in people:
@@ -56,4 +80,4 @@ def find_possible_laptops(laptops: List[Laptop], person: Person) -> List[Laptop]
 # exercise_10.py:29: error: Unexpected keyword argument "preferred_operating_system" for "Person"; did you mean "preferred_operating_systems"?  [call-arg]
 # exercise_10.py:30: error: Unexpected keyword argument "preferred_operating_system" for "Person"; did you mean "preferred_operating_systems"?  [call-arg]
 
-# Fix all of the places that mypy tells you need changing. Make sure the program works as you’d expect.
+# Fix all of the places that mypy tells you need changing. Make sure the program works as you’d expect.

sprint-5-prep-exercises/exercise_11.py

@@ -5,49 +5,57 @@
 # Tells the user how many laptops the library has that have that operating system.
 # If there is an operating system that has more laptops available, tells the user that if they’re willing to accept that operating system they’re more likely to get a laptop.
 
-# You should convert the age and preferred operating system input from the user into more constrained types as quickly as possible, 
+# You should convert the age and preferred operating system input from the user into more constrained types as quickly as possible,
 # and should output errors to stderr and terminate the program with a non-zero exit code if the user input bad values.
 
 # ----- Imports
+import sys
 from dataclasses import dataclass
 from enum import Enum
-import sys
 
- # ----- Classes and Enums
+
+# ----- Classes and Enums
 class OperatingSystem(Enum):
     MACOS = "macOS"
     ARCH = "Arch Linux"
     UBUNTU = "Ubuntu"
     WINDOWS = "Windows"
 
+
 @dataclass(frozen=True)
 class Person:
     name: str
     age: int
     preferred_operating_system: OperatingSystem
 
+
 @dataclass(frozen=True)
 class Laptop:
     id: int
     operating_system: OperatingSystem
 
- # ----- Functions
+
+# ----- Functions
 def count_laptops(laptops: list[Laptop], laptop_counts: dict[str, int]):
     for laptop in laptops:
-        laptop_counts[laptop.operating_system] += 1 
+        laptop_counts[laptop.operating_system] += 1
+
 
 def check_laptop_abundance(user: Person, laptop_counts: dict[OperatingSystem, int]):
     abundant_laptops = []
     for laptop in laptop_counts:
         if laptop_counts[laptop] > laptop_counts[user.preferred_operating_system]:
             abundant_laptops.append(laptop.value)
     if len(abundant_laptops) > 0:
-        print("\nIf you are willing to accept another operating system you may get a laptop sooner.")
+        print(
+            "\nIf you are willing to accept another operating system you may get a laptop sooner."
+        )
         print("We have more laptops available with the following OS:")
         for laptop in abundant_laptops:
             print(laptop)
-            
- # ----- Data and Constants
+
+
+# ----- Data and Constants
 laptops = [
     Laptop(id=1, operating_system=OperatingSystem.ARCH),
     Laptop(id=2, operating_system=OperatingSystem.ARCH),
@@ -62,10 +70,10 @@ def check_laptop_abundance(user: Person, laptop_counts: dict[OperatingSystem, in
     OperatingSystem.MACOS: 0,
     OperatingSystem.ARCH: 0,
     OperatingSystem.UBUNTU: 0,
-    OperatingSystem.WINDOWS: 0
+    OperatingSystem.WINDOWS: 0,
 }
 
- # ----- Script
+# ----- Script
 user_name = input("Please enter your full name:\n")
 user_age_str = input("Please enter your age:\n")
 
@@ -74,15 +82,20 @@ def check_laptop_abundance(user: Person, laptop_counts: dict[OperatingSystem, in
 except ValueError:
     sys.exit("Error: Age should be a number.")
 
-user_operating_system_str = input("Please enter your preferred operating system (options: ARCH, UBUNTU, MACOS, WINDOWS):\n")
+user_operating_system_str = input(
+    "Please enter your preferred operating system (options: Arch, Ubuntu, MacOS, Windows):\n"
+).upper()
 
 if user_operating_system_str not in OperatingSystem.__members__:
-    sys.exit("Error: Operating system should be written in all caps from given options.")
-else: user_operating_system = OperatingSystem[user_operating_system_str]
+    sys.exit("Error: Please enter a valid operating system from the given options.")
+else:
+    user_operating_system = OperatingSystem[user_operating_system_str]
 
 user = Person(user_name, user_age, user_operating_system)
 
 count_laptops(laptops, laptop_counts)
-print(f"\nThe number of available laptops with {user_operating_system.value} is: {laptop_counts[user_operating_system]}")
+print(
+    f"\nThe number of available laptops with {user_operating_system.value} is: {laptop_counts[user_operating_system]}"
+)
 
-check_laptop_abundance(user, laptop_counts)
+check_laptop_abundance(user, laptop_counts)