made changes per review

Author: d-odumosu

Sprint-1/fix/median.js

@@ -9,8 +9,7 @@ function calculateMedian(list) {
   if (!Array.isArray(list)) {
     return null;
   }
-  const arrCopy = [...list];
-  const filteredNumbers = arrCopy.filter((num) => Number.isFinite(num));
+  const filteredNumbers = list.filter((num) => Number.isFinite(num));
 
   if (filteredNumbers.length === 0) {
     return null;

Sprint-1/implement/dedupe.js

@@ -3,7 +3,7 @@ function dedupe(elements) {
     return [];
   }
 
-  return elements.filter((item, index) => elements.indexOf(item) === index);
+  return [...new Set(elements)];
 }
 
 module.exports = dedupe;

Sprint-1/implement/dedupe.test.js

@@ -33,9 +33,12 @@ const testCaseNoDuplicates = [
     expected: [2, 3, 4, 5, 6, 7],
   },
 ];
+const result = dedupe(input);
+
 testCaseNoDuplicates.forEach(({ input, expected }) => {
   test("given an array with no duplicates, return a copy of the array", () => {
     expect(dedupe(input)).toEqual(expected);
+    expect(result).not.toBe(input);
   });
 });
 

Sprint-1/implement/max.js

@@ -6,7 +6,7 @@ function findMax(elements) {
     return typeof number === "number";
   });
   if (elementLists.length === 0) {
-    return undefined;
+    return 0;
   }
   if (elementLists.length === 1) {
     return elementLists[0];
@@ -19,5 +19,4 @@ function findMax(elements) {
   }
   return max;
 }
-console.log(findMax([-1, 0, -2]));
 module.exports = findMax;

Sprint-1/implement/max.test.js

@@ -96,9 +96,9 @@ testCaseArrayWithNonNumberValues.forEach(({ input, expected }) => {
 // When passed to the max function
 // Then it should return the least surprising value given how it behaves for all other inputs
 const testCaseArrayWithOnlyNonNumberValues = [
-  { input: ["hello", "world"], expected: undefined },
-  { input: [null, undefined, true, false], expected: undefined },
-  { input: [{}, [], "test"], expected: undefined },
+  { input: ["hello", "world", "300"], expected: 0 },
+  { input: [null, undefined, true, false], expected: 0 },
+  { input: [{}, [], "test"], expected: 0 },
 ];
 testCaseArrayWithOnlyNonNumberValues.forEach(({ input, expected }) => {
   test("given an array with only non-number values, returns undefined", () => {

Sprint-1/implement/sum.js

@@ -1,9 +1,10 @@
 function sum(elements) {
-  if (elements.length === 0) {
-    return 0;
-  }
   const elementsList = elements.filter((element) => {
-    return typeof element === "number";
+    return (
+      typeof element === "number" &&
+      !Number.isNaN(element) &&
+      Number.isFinite(element)
+    );
   });
   if (elementsList.length === 1) {
     return elementsList[0];

Sprint-1/implement/sum.test.js

@@ -74,7 +74,7 @@ testCaseNonNumerical.forEach(({ input, expected }) => {
 // Then it should return the least surprising value given how it behaves for all other inputs
 const testNonNumberValues = [
   { input: ["hello", "world"], expected: 0 },
-  { input: [null, undefined], expected: 0 },
+  { input: [null, undefined, NaN, Infinity, -Infinity], expected: 0 },
   { input: [true, false, "apple"], expected: 0 },
   { input: [{}, "10", null], expected: 0 },
   { input: ["apple", null, undefined, false], expected: 0 },

Sprint-1/refactor/includes.js

@@ -1,21 +1,13 @@
 // Refactor the implementation of includes to use a for...of loop
 
-//my comments
-//make a copy of the array
-//check if target is in the array
 function includes(list, target) {
-  const targetFoundInArr = [];
   for (const li of list) {
     if (li === target) {
-      targetFoundInArr.push(li);
+      return true;
     }
   }
-  if (targetFoundInArr.length === 0) {
-    return false;
-  }
-  if (targetFoundInArr.length >= 1) {
-    return true;
-  }
+
+  return false;
 }
 console.log(includes([1, 2, 3, 4, 55, 6, null, 6, 7], 6));
 module.exports = includes;