generalise variables in js, remove scroll bar using css morgin:0, change <p> to <blockquote in Html

Author: vmoratti

Sprint-3/quote-generator/index.html

@@ -13,15 +13,12 @@ <h1>Quote Generator</h1>
     </header> 
     <main>
       <section>
-      <p id="quote"></p>
+      <blockquote id="quote"></blockquote>
       <p id="author"></p>
-    <div></div>
     </section>
     </main>
     <section>
       <button type="button" id="new-quote">New quote</button>
     </section>
-    
-    
   </body>
 </html>

Sprint-3/quote-generator/quotes.js

@@ -498,17 +498,17 @@ const quotes = [
 //4. when an event happens produce author of that quote in the other <p>
 const button = document.querySelector("#new-quote");
 const initialQuote = pickFromArray(quotes);
-const placeInitialQuote = document.querySelector("#quote");
-const placeInitialAuthor = document.querySelector("#author");
-placeInitialQuote.innerText = `${initialQuote.quote}`;
-placeInitialAuthor.innerText = `${initialQuote.author}`;
+const quotePlacement = document.querySelector("#quote");
+const authorPlacement = document.querySelector("#author");
+quotePlacement.innerText = `${initialQuote.quote}`;
+authorPlacement.innerText = `${initialQuote.author}`;
 
 function newQuoteEveryTime() {
   const quote = pickFromArray(quotes);
-  const quotePlace = document.querySelector("#quote");
-  const authorPlace = document.querySelector("#author");
-  quotePlace.innerText = `${quote.quote}`;
-  authorPlace.innerText = `${quote.author}`;
+  //const quotePlace = document.querySelector("#quote");
+  //const authorPlace = document.querySelector("#author");
+  quotePlacement.innerText = `${quote.quote}`;
+  authorPlacement.innerText = `${quote.author}`;
 }
 
 button.addEventListener("click", newQuoteEveryTime);

Sprint-3/quote-generator/style.css

@@ -5,14 +5,16 @@ h1 {
 }
 
 body {
+    margin: 0;
     font-family: Arial, sans-serif;
     background: rgb(24, 25, 24);
 
     display: flex;
     flex-direction: column;
     align-items: center;
 
-    min-height: 100vh;
+    min-height: 100dvh;
+
 }
 #quote {
     max-width: 700px;
@@ -35,7 +37,6 @@ body {
     font-size: 18px;
     color: white;
     background-color: rgb(225, 71, 36);
-
     cursor: pointer;
 }