Skip to content

Commit 37febb7

Browse files
committed
Refactor HTML semantics and improve colour contrast
1 parent e7992d3 commit 37febb7

2 files changed

Lines changed: 11 additions & 16 deletions

File tree

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!DOCTYPE html>
1+
<!doctype html>
22
<html lang="en">
33
<head>
44
<meta charset="UTF-8" />
@@ -11,17 +11,12 @@
1111
<script src="quotes.js" defer></script>
1212
</head>
1313
<body>
14-
<!-- Outer orange container -->
15-
<div class="outer-container">
16-
<!-- Your original title -->
17-
<h1>hello there</h1>
18-
19-
<!-- Inner white card -->
20-
<div class="quote-box">
21-
<p id="quote"></p>
22-
<p id="author"></p>
14+
<main>
15+
<section class="quote-box">
16+
<blockquote id="quote"></blockquote>
17+
<cite id="author"></cite>
2318
<button type="button" id="new-quote">New quote</button>
24-
</div>
25-
</div>
19+
</section>
20+
</main>
2621
</body>
2722
</html>

‎Sprint-3/quote-generator/style.css‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
}
66

77
body {
8-
background-color: #f3a83c;
8+
background-color: #8a4b00;
99
font-family: Georgia, "Times New Roman", Times, serif;
1010
display: flex;
1111
justify-content: center;
@@ -38,7 +38,7 @@ h1 {
3838

3939
/* Quote text styling with orange quote mark added automatically */
4040
#quote {
41-
color: #f3a83c;
41+
color: #8a4b00;
4242
font-size: 22px;
4343
line-height: 1.4;
4444
margin-bottom: 15px;
@@ -54,7 +54,7 @@ h1 {
5454

5555
/* Author text styling right-aligned */
5656
#author {
57-
color: #f3a83c;
57+
color: #8a4b00;
5858
font-size: 18px;
5959
text-align: right;
6060
margin-bottom: 25px;
@@ -68,7 +68,7 @@ h1 {
6868
#new-quote {
6969
display: block;
7070
margin-left: auto;
71-
background-color: #f3a83c;
71+
background-color: #8a4b00;
7272
color: #ffffff;
7373
border: none;
7474
padding: 12px 22px;

0 commit comments

Comments
 (0)