Merge pull request #1462 from CodeYourFuture/update-solutions

Bring solutions branch up to date

Author: illicitonion

.github/FUNDING.yml

@@ -1,13 +1,2 @@
-# These are supported funding model platforms
-
 github: CodeYourFuture
-patreon: # Replace with a single Patreon username
-open_collective: # Replace with a single Open Collective username
-ko_fi: # Replace with a single Ko-fi username
-tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel
-community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
-liberapay: # Replace with a single Liberapay username
-issuehunt: # Replace with a single IssueHunt username
-otechie: # Replace with a single Otechie username
-lfx_crowdfunding: # Replace with a single LFX Crowdfunding project-name e.g., cloud-foundry
 custom: https://codeyourfuture.io/donate

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,18 @@
+name: Validate PR Metadata
+on:
+  pull_request_target:
+    types:
+      - labeled
+      - unlabeled
+      - opened
+      - edited
+      - reopened
+
+jobs:
+  validate_pr_metadata:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: CodeYourFuture/actions/validate-pr-metadata@main
+        with:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/ISSUE_TEMPLATE/pd-assignment.yml

@@ -1,4 +1,6 @@
 node_modules
 .DS_Store
 .vscode
-**/.DS_Store
+**/.DS_Store
+.idea
+package-lock.json

.github/ISSUE_TEMPLATE/tech-ed-assignment.yml

@@ -5,6 +5,7 @@
     "streetsidesoftware.code-spell-checker",
     "eamodio.gitlens",
     "ritwickdey.LiveServer",
-    "vsliveshare.vsliveshare"
+    "vsliveshare.vsliveshare",
+    "Orta.vscode-jest"
   ]
 }

.github/pull_request_template.md

@@ -1,43 +1,35 @@
 // Fix this implementation
 // Start by running the tests for this function
-// If you're in the week-1 directory, you can run npm test -- fix to run the tests in the fix directory
+// If you're in the Sprint-1 directory, you can run `npm test -- fix` to run the tests in the fix directory
 
-// Old Code:
-
-// function calculateMedian(list) {
-//   const middleIndex = Math.floor(list.length / 2);
-//   const median = list.splice(middleIndex, 1)[0];
-//   return median;
-// }
+// Hint: Please consider scenarios when 'list' isn't an array, is empty,
+// or contains values that aren't numbers (the function is expected to throw - see the tests).
 
 // Explanation:
-// The original implementation has several mistakes:
-// 1 - .splice() mutates or changes the original array. We don't want this to happen.
-// 2 - We actually don't need .splice() or any other method to find a median.
-// 3 - We must sort the array before we search for the median.
-// 4 - We should check if the 'list' parameter actually has numbers, otherwise try to filter
-// out all non-numeric values and throw an error or return null if there are no numeric values.
-
-
-// Example of a function calculating median and returning null in case no numeric values provided.
+// Check the input first and throw if there is no sensible median to return.
+// Sort a copy so the caller's array is not mutated, then read the middle
+// element, or the average of the two middle elements when the length is even.
 
 function calculateMedian(list) {
   if (!Array.isArray(list)) {
-    return null;
+    throw new Error("calculateMedian requires an array of numbers");
   }
-  const onlyNumberList = list.filter(item => typeof item === 'number' && !isNaN(item));
-
-  if (!onlyNumberList.length) {
-    return null;
-  } else {
-    const sortedList = onlyNumberList.sort((current, next) => current - next);
-    const indexNearMiddleOfArray = Math.floor(sortedList.length / 2);
-    if (sortedList.length % 2 === 0) {
-      return (sortedList[indexNearMiddleOfArray - 1] + sortedList[indexNearMiddleOfArray]) / 2;
-    } else {
-      return sortedList[indexNearMiddleOfArray];
+  for (const item of list) {
+    if (typeof item !== "number") {
+      throw new Error("calculateMedian requires an array of numbers");
     }
   }
+  if (list.length === 0) {
+    throw new Error("calculateMedian requires a non-empty array");
+  }
+
+  const sorted = [...list].sort((a, b) => a - b);
+  const middleIndex = Math.floor(sorted.length / 2);
+
+  if (sorted.length % 2 === 0) {
+    return (sorted[middleIndex - 1] + sorted[middleIndex]) / 2;
+  }
+  return sorted[middleIndex];
 }
 
 module.exports = calculateMedian;