Skip to content

Commit 2754820

Browse files
committed
refactor: precomputing prefixes for faster lookup.
1 parent f13588d commit 2754820

1 file changed

Lines changed: 8 additions & 12 deletions

File tree

‎Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py‎

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,14 @@ def find_longest_common_prefix(strings: List[str]):
77
88
In the event that an empty list, a list containing one string, or a list of strings with no common prefixes is passed, the empty string will be returned.
99
"""
10+
seen = set()
1011
longest = ""
11-
for string_index, string in enumerate(strings):
12-
for other_string in strings[string_index+1:]:
13-
common = find_common_prefix(string, other_string)
14-
if len(common) > len(longest):
15-
longest = common
16-
return longest
12+
for string in strings:
13+
for i in range(1,len(string)+1) :
14+
prefix = string[:i]
15+
if prefix in seen and len(prefix) > len(longest):
16+
longest = prefix
1717

18+
seen.add(prefix)
19+
return longest
1820

19-
def find_common_prefix(left: str, right: str) -> str:
20-
min_length = min(len(left), len(right))
21-
for i in range(min_length):
22-
if left[i] != right[i]:
23-
return left[:i]
24-
return left[:min_length]

0 commit comments

Comments
 (0)