Skip to content

Commit f459311

Browse files
committed
Refactor search files feature into modular search modes and utility functions
- [Fragment] in search mode of search_files_by_term is never used - each search mode should be handled by a separte file - extract flows from utils to `apps/editor/src/features/search-files/search-modes`. We also prefer 'search mode' suffix than 'flow' - refactor out `apps/editor/src/features/search-files/utils/search-files-by-term.ts` - inline `apps/editor/src/features/search-files/utils/get-keyword-regexes.ts` - give better name to file/exported method `apps/editor/src/features/search-files/utils/fetch-relevant-files-from-api.ts` - place `apps/editor/src/features/search-files/actions/search-files.ts` in `apps/editor/src/features/search-files` - in a multi-root folder workspaces, results should be grouped by the root folder name by using separators - in multi-root folder workspaces, in search results we group items by workspace. The issue is that these groups are in a wrong order. - we never search in any 'other' workspace folder than those in the workspace
1 parent 58edb53 commit f459311

15 files changed

Lines changed: 973 additions & 623 deletions

‎apps/editor/src/features/search-files/actions/search-files.ts‎

Lines changed: 0 additions & 341 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export * from './actions/search-files'
1+
export * from './search-files'

0 commit comments

Comments
 (0)