Skip to content

Commit 7c65a2d

Browse files
committed
Refine prompt validation checks and execution order in prompt handlers
- in 'edit' mode, context is required, so sending with 'ctrl' should immediately result in notification about empty context ├── apps │ └── editor │ └── src │ └── views │ └── prompt │ ├── backend │ │ ├── message-handlers │ │ │ ├── handle-autofill.ts │ │ │ ├── handle-invoke-agentic-cli.ts │ │ │ ├── handle-make-api-call.ts │ │ │ └── utils │ │ │ ├── build-prompt-payload.ts │ │ │ └── show-context-cannot-be-empty-warning.ts │ │ └── prompt-view-provider.ts │ └── frontend │ └── Main │ ├── Main.tsx │ └── MainView │ └── MainView.tsx └── packages └── ui └── src └── components └── editor └── common └── prompts └── PromptField └── hooks └── use-handlers └── handle-submit.ts
1 parent 6a11af4 commit 7c65a2d

2 files changed

Lines changed: 24 additions & 24 deletions

File tree

‎apps/editor/src/views/prompt/backend/message-handlers/handle-autofill.ts‎

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,29 @@ export const handle_autofill = async (params: {
3232
return
3333
}
3434

35+
await vscode.workspace.saveAll()
36+
37+
const {
38+
other_files,
39+
recent_files,
40+
collected_files,
41+
processed_instructions,
42+
processed_completed_tasks,
43+
skill_definitions,
44+
accuracy_boost
45+
} = await build_prompt_payload({
46+
prompt_view_provider: params.prompt_view_provider,
47+
remove_images: true
48+
})
49+
50+
if (
51+
params.prompt_view_provider.web_prompt_type === 'edit' &&
52+
!collected_files
53+
) {
54+
await show_context_cannot_be_empty_warning(params.prompt_view_provider)
55+
return
56+
}
57+
3558
const resolution = await resolve_web_configuration({
3659
prompt_view_provider: params.prompt_view_provider,
3760
web_configuration_name: params.web_configuration_name,
@@ -51,34 +74,11 @@ export const handle_autofill = async (params: {
5174
})
5275
}
5376

54-
await vscode.workspace.saveAll()
55-
5677
let sent = false
5778

5879
const current_instructions =
5980
params.prompt_view_provider.current_instructions.trim()
6081

61-
const {
62-
other_files,
63-
recent_files,
64-
collected_files,
65-
processed_instructions,
66-
processed_completed_tasks,
67-
skill_definitions,
68-
accuracy_boost
69-
} = await build_prompt_payload({
70-
prompt_view_provider: params.prompt_view_provider,
71-
remove_images: true
72-
})
73-
74-
if (
75-
params.prompt_view_provider.web_prompt_type === 'edit' &&
76-
!collected_files
77-
) {
78-
await show_context_cannot_be_empty_warning(params.prompt_view_provider)
79-
return
80-
}
81-
8282
let output_formatting: string | undefined = undefined
8383
let completed_tasks: string[] | undefined = undefined
8484
const user_instructions = processed_instructions

‎apps/editor/src/views/prompt/backend/message-handlers/handle-make-api-call.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export const handle_make_api_call = async (
6363
prompt_view_provider
6464
})
6565

66-
if (!collected_files) {
66+
if (prompt_type === 'edit' && !collected_files) {
6767
await show_context_cannot_be_empty_warning(prompt_view_provider)
6868
return
6969
}

0 commit comments

Comments
 (0)