Skip to content

Commit 552ad89

Browse files
committed
Restructure settings page and consolidate i18n translations for API calls and chatbots including a new defaults group
- we're missing the ability to set default 'find relevant files' configuration (above voice input)
1 parent 22dc7dc commit 552ad89

10 files changed

Lines changed: 980 additions & 928 deletions

File tree

‎apps/editor/src/views/settings/frontend/Home/Home.tsx‎

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ export type NavItem =
3131
| 'section:api-calls'
3232
| 'section:api-calls:group:model-providers'
3333
| 'section:api-calls:group:api-configurations'
34+
| 'section:api-calls:group:api-defaults'
3435
| 'section:api-calls:group:api-behavior'
3536
| 'section:api-calls:group:system-instructions'
3637

@@ -67,35 +68,39 @@ const NAV_ITEMS_CONFIG: NavConfigItem[] = [
6768
},
6869
{
6970
id: 'section:chatbots',
70-
label: 'sections.chatbots'
71+
label: 'chatbots.title'
7172
},
7273
{
7374
id: 'section:chatbots:group:web-configurations',
74-
label: 'web-configurations.configurations.title'
75+
label: 'chatbots.configurations.title'
7576
},
7677
{
7778
id: 'section:chatbots:group:chatbots-other',
78-
label: 'web-configurations.behavior.title'
79+
label: 'chatbots.behavior.title'
7980
},
8081
{
8182
id: 'section:api-calls',
82-
label: 'sections.api-configurations'
83+
label: 'api-calls.title'
8384
},
8485
{
8586
id: 'section:api-calls:group:model-providers',
86-
label: 'sections.model-providers'
87+
label: 'api-calls.model-providers.title'
8788
},
8889
{
8990
id: 'section:api-calls:group:api-configurations',
90-
label: 'configurations.title'
91+
label: 'api-calls.configurations.title'
92+
},
93+
{
94+
id: 'section:api-calls:group:api-defaults',
95+
label: 'api-calls.configurations.default-configurations.title'
9196
},
9297
{
9398
id: 'section:api-calls:group:api-behavior',
94-
label: 'configurations.behavior.title'
99+
label: 'api-calls.configurations.behavior.title'
95100
},
96101
{
97102
id: 'section:api-calls:group:system-instructions',
98-
label: 'configurations.system-instructions.title'
103+
label: 'api-calls.configurations.system-instructions.title'
99104
}
100105
]
101106

@@ -193,6 +198,7 @@ export const Home: React.FC<Props> = (props) => {
193198
'section:api-calls': null,
194199
'section:api-calls:group:model-providers': null,
195200
'section:api-calls:group:api-configurations': null,
201+
'section:api-calls:group:api-defaults': null,
196202
'section:api-calls:group:api-behavior': null,
197203
'section:api-calls:group:system-instructions': null
198204
})

‎apps/editor/src/views/settings/frontend/Home/sections/ApiConfigurationsSection.tsx‎

Lines changed: 67 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,12 @@ export const ApiConfigurationsSection = forwardRef<HTMLDivElement, Props>(
7070
return (
7171
<UiSection
7272
ref={ref}
73-
title={t('sections.api-configurations')}
74-
subtitle={t('configurations.subtitle')}
73+
title={t('api-calls.title')}
74+
subtitle={t('api-calls.configurations.subtitle')}
7575
>
7676
<UiNotice type="info">
7777
<Translation
78-
id="model-providers.notice.credentials"
78+
id="api-calls.model-providers.notice.credentials"
7979
components={{
8080
link: (
8181
<a
@@ -98,10 +98,10 @@ export const ApiConfigurationsSection = forwardRef<HTMLDivElement, Props>(
9898
props.set_section_ref('section:api-calls:group:model-providers', el)
9999
}
100100
>
101-
<UiGroup title={t('sections.model-providers')}>
101+
<UiGroup title={t('api-calls.model-providers.title')}>
102102
{!props.providers.length && (
103103
<UiNotice type="warning">
104-
{t('model-providers.notice.missing')}
104+
{t('api-calls.model-providers.notice.missing')}
105105
</UiNotice>
106106
)}
107107
<ModelProvidersSection
@@ -125,10 +125,10 @@ export const ApiConfigurationsSection = forwardRef<HTMLDivElement, Props>(
125125
)
126126
}
127127
>
128-
<UiGroup title={t('configurations.title')}>
128+
<UiGroup title={t('api-calls.configurations.title')}>
129129
{!props.api_configurations.length && (
130130
<UiNotice type="warning">
131-
{t('configurations.notice.missing')}
131+
{t('api-calls.configurations.notice.missing')}
132132
</UiNotice>
133133
)}
134134
{props.api_configurations && (
@@ -141,9 +141,9 @@ export const ApiConfigurationsSection = forwardRef<HTMLDivElement, Props>(
141141
on_add={props.on_add_api_configuration}
142142
translations={{
143143
add_title: t('action.add-new'),
144-
item_text: t('configurations.item'),
145-
items_text: t('configurations.items'),
146-
items_text_many: t('configurations.items-many')
144+
item_text: t('api-calls.configurations.item'),
145+
items_text: t('api-calls.configurations.items'),
146+
items_text_many: t('api-calls.configurations.items-many')
147147
}}
148148
render_content={(config) => {
149149
const details: string[] = [config.model_provider_name]
@@ -182,7 +182,7 @@ export const ApiConfigurationsSection = forwardRef<HTMLDivElement, Props>(
182182
<>
183183
<IconButton
184184
codicon_icon="insert"
185-
title={t('configurations.action.insert')}
185+
title={t('api-calls.configurations.action.insert')}
186186
on_click={() =>
187187
props.on_add_api_configuration({
188188
insertion_index: index
@@ -191,14 +191,14 @@ export const ApiConfigurationsSection = forwardRef<HTMLDivElement, Props>(
191191
/>
192192
<IconButton
193193
codicon_icon="edit"
194-
title={t('configurations.action.edit')}
194+
title={t('api-calls.configurations.action.edit')}
195195
on_click={() =>
196196
props.on_edit_api_configuration(config.id)
197197
}
198198
/>
199199
<IconButton
200200
codicon_icon="trash"
201-
title={t('configurations.action.delete')}
201+
title={t('api-calls.configurations.action.delete')}
202202
on_click={(e) => {
203203
e.stopPropagation()
204204
props.on_delete_api_configuration(config.id)
@@ -208,10 +208,21 @@ export const ApiConfigurationsSection = forwardRef<HTMLDivElement, Props>(
208208
)}
209209
/>
210210
)}
211+
</UiGroup>
212+
</div>
213+
214+
<div
215+
ref={(el) =>
216+
props.set_section_ref('section:api-calls:group:api-defaults', el)
217+
}
218+
>
219+
<UiGroup
220+
title={t('api-calls.configurations.default-configurations.title')}
221+
>
211222
{props.api_configurations.length > 0 && (
212223
<>
213224
<DefaultConfigurationSelector
214-
title={t('configurations.tool.intelligent-update')}
225+
title={t('api-calls.configurations.tool.intelligent-update')}
215226
value={props.defaults['intelligent-update'] || null}
216227
configurations={selector_configurations}
217228
on_unset={() =>
@@ -226,12 +237,12 @@ export const ApiConfigurationsSection = forwardRef<HTMLDivElement, Props>(
226237
)
227238
}
228239
translations={{
229-
select: t('configurations.action.select-default'),
230-
unset: t('configurations.action.unset-default')
240+
select: t('api-calls.configurations.action.select-default'),
241+
unset: t('api-calls.configurations.action.unset-default')
231242
}}
232243
/>
233244
<DefaultConfigurationSelector
234-
title={t('configurations.tool.code-at-cursor')}
245+
title={t('api-calls.configurations.tool.code-at-cursor')}
235246
value={props.defaults['code-at-cursor'] || null}
236247
configurations={selector_configurations}
237248
on_unset={() =>
@@ -244,12 +255,12 @@ export const ApiConfigurationsSection = forwardRef<HTMLDivElement, Props>(
244255
props.on_select_default_api_configuration('code-at-cursor')
245256
}
246257
translations={{
247-
select: t('configurations.action.select-default'),
248-
unset: t('configurations.action.unset-default')
258+
select: t('api-calls.configurations.action.select-default'),
259+
unset: t('api-calls.configurations.action.unset-default')
249260
}}
250261
/>
251262
<DefaultConfigurationSelector
252-
title={t('configurations.tool.commit-messages')}
263+
title={t('api-calls.configurations.tool.commit-messages')}
253264
value={props.defaults['commit-messages'] || null}
254265
configurations={selector_configurations}
255266
on_unset={() =>
@@ -262,12 +273,33 @@ export const ApiConfigurationsSection = forwardRef<HTMLDivElement, Props>(
262273
props.on_select_default_api_configuration('commit-messages')
263274
}
264275
translations={{
265-
select: t('configurations.action.select-default'),
266-
unset: t('configurations.action.unset-default')
276+
select: t('api-calls.configurations.action.select-default'),
277+
unset: t('api-calls.configurations.action.unset-default')
278+
}}
279+
/>
280+
<DefaultConfigurationSelector
281+
title={t('api-calls.configurations.tool.find-relevant-files')}
282+
value={props.defaults['find-relevant-files'] || null}
283+
configurations={selector_configurations}
284+
on_unset={() =>
285+
props.on_set_default_api_configuration(
286+
'find-relevant-files',
287+
null
288+
)
289+
}
290+
on_select={() =>
291+
props.on_select_default_api_configuration(
292+
'find-relevant-files'
293+
)
294+
}
295+
translations={{
296+
select: t('api-calls.configurations.action.select-default'),
297+
unset: t('api-calls.configurations.action.unset-default')
267298
}}
268299
/>
300+
269301
<DefaultConfigurationSelector
270-
title={t('configurations.tool.voice-input')}
302+
title={t('api-calls.configurations.tool.voice-input')}
271303
value={props.defaults['voice-input'] || null}
272304
configurations={selector_configurations}
273305
on_unset={() =>
@@ -277,8 +309,8 @@ export const ApiConfigurationsSection = forwardRef<HTMLDivElement, Props>(
277309
props.on_select_default_api_configuration('voice-input')
278310
}
279311
translations={{
280-
select: t('configurations.action.select-default'),
281-
unset: t('configurations.action.unset-default')
312+
select: t('api-calls.configurations.action.select-default'),
313+
unset: t('api-calls.configurations.action.unset-default')
282314
}}
283315
/>
284316
</>
@@ -291,11 +323,13 @@ export const ApiConfigurationsSection = forwardRef<HTMLDivElement, Props>(
291323
props.set_section_ref('section:api-calls:group:api-behavior', el)
292324
}
293325
>
294-
<UiGroup title={t('configurations.behavior.title')}>
326+
<UiGroup title={t('api-calls.configurations.behavior.title')}>
295327
<UiItem
296-
title={t('configurations.intelligent-update.auto-run.title')}
328+
title={t(
329+
'api-calls.configurations.intelligent-update.auto-run.title'
330+
)}
297331
description={t(
298-
'configurations.intelligent-update.auto-run.description'
332+
'api-calls.configurations.intelligent-update.auto-run.description'
299333
)}
300334
slot_right={
301335
<UiToggler
@@ -316,13 +350,15 @@ export const ApiConfigurationsSection = forwardRef<HTMLDivElement, Props>(
316350
}
317351
>
318352
<UiGroup
319-
title={t('configurations.system-instructions.title')}
353+
title={t('api-calls.configurations.system-instructions.title')}
320354
is_last
321355
>
322356
<UiItem
323-
title={t('configurations.edit-files-system-instructions.title')}
357+
title={t(
358+
'api-calls.configurations.edit-files-system-instructions.title'
359+
)}
324360
description={t(
325-
'configurations.edit-files-system-instructions.description'
361+
'api-calls.configurations.edit-files-system-instructions.description'
326362
)}
327363
is_toggleable
328364
translations={{

‎apps/editor/src/views/settings/frontend/Home/sections/ModelProvidersSection.tsx‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ export const ModelProvidersSection: React.FC<ModelProvidersSectionProps> = (
3131
on_add={props.on_add_provider}
3232
translations={{
3333
add_title: t('action.add-new'),
34-
item_text: t('model-providers.item'),
35-
items_text: t('model-providers.items')
34+
item_text: t('api-calls.model-providers.item'),
35+
items_text: t('api-calls.model-providers.items')
3636
}}
3737
render_content={(provider) => {
3838
const is_localhost =
@@ -79,17 +79,17 @@ export const ModelProvidersSection: React.FC<ModelProvidersSectionProps> = (
7979
<>
8080
<IconButton
8181
codicon_icon="insert"
82-
title={t('model-providers.action.insert')}
82+
title={t('api-calls.model-providers.action.insert')}
8383
on_click={() => props.on_add_provider({ insertion_index: index })}
8484
/>
8585
<IconButton
8686
codicon_icon="edit"
87-
title={t('model-providers.action.edit')}
87+
title={t('api-calls.model-providers.action.edit')}
8888
on_click={() => props.on_edit_provider(provider.name)}
8989
/>
9090
<IconButton
9191
codicon_icon="trash"
92-
title={t('model-providers.action.delete')}
92+
title={t('api-calls.model-providers.action.delete')}
9393
on_click={() => props.on_delete_provider(provider.name)}
9494
/>
9595
</>

0 commit comments

Comments
 (0)