Remove Unnecessary Delegate Method

Author: thecoolwinter

CodeEdit/Features/TerminalEmulator/Views/CEActiveTaskTerminalView.swift

@@ -54,7 +54,7 @@ class CEActiveTaskTerminalView: CELocalShellTerminalView {
                     self.enableOutput = false
                     let chunks = string.split(separator: ";")
                     guard chunks.count == 2, let code = Int32(chunks[1]) else { return }
-                    self.processDelegate?.userProcessTerminated(exitCode: code)
+
                     if self.activeTask.status == .running {
                         self.activeTask.handleProcessFinished(terminationStatus: code)
                     }

CodeEdit/Features/TerminalEmulator/Views/CELocalShellTerminalView.swift

@@ -42,10 +42,6 @@ protocol CELocalShellTerminalViewDelegate: AnyObject {
     /// - Parameter exitCode: the exit code returned by the process, or nil if this was an error caused during
     ///                       the IO reading/writing
     func processTerminated(source: TerminalView, exitCode: Int32?)
-
-    /// Invoked when the shell integration notifies the terminal that a user-executed command has finished with an exit
-    /// code.
-    func userProcessTerminated(exitCode: Int32)
 }
 
 // MARK: - CELocalShellTerminalView

CodeEdit/Features/TerminalEmulator/Views/TerminalEmulatorView+Coordinator.swift

@@ -13,9 +13,12 @@ extension TerminalEmulatorView {
         private let terminalID: UUID
         public var onTitleChange: (_ title: String) -> Void
 
-        init(terminalID: UUID, onTitleChange: @escaping (_ title: String) -> Void) {
+        var mode: TerminalMode
+
+        init(terminalID: UUID, mode: TerminalMode, onTitleChange: @escaping (_ title: String) -> Void) {
             self.terminalID = terminalID
             self.onTitleChange = onTitleChange
+            self.mode = mode
             super.init()
         }
 
@@ -31,11 +34,11 @@ extension TerminalEmulatorView {
             guard let exitCode else {
                 return
             }
-            source.feed(text: "Exit code: \(exitCode)\n\r\n")
-            source.feed(text: "To open a new session, create a new terminal tab.")
-            TerminalCache.shared.removeCachedView(terminalID)
+            if case .shell = mode {
+                source.feed(text: "Exit code: \(exitCode)\n\r\n")
+                source.feed(text: "To open a new session, create a new terminal tab.")
+                TerminalCache.shared.removeCachedView(terminalID)
+            }
         }
-
-        func userProcessTerminated(exitCode: Int32) { }
     }
 }

CodeEdit/Features/TerminalEmulator/Views/TerminalEmulatorView.swift

@@ -218,6 +218,6 @@ struct TerminalEmulatorView: NSViewRepresentable {
     }
 
     func makeCoordinator() -> Coordinator {
-        Coordinator(terminalID: terminalID, onTitleChange: onTitleChange)
+        Coordinator(terminalID: terminalID, mode: mode, onTitleChange: onTitleChange)
     }
 }