Skip to content

Scoreboard schemas describe an other_games_min_quality value the enum does not offer #426

Description

@ChuckBuilds

other_games_min_quality is declared in every scoreboard's config_schema.json with:

"enum": ["any", "ranked"]

but its description reads:

'ranked' shows only games involving a nationally ranked team; 'broadcast' also allows games with a national TV listing; 'any' is the old behaviour...

There is no broadcast value. The web UI renders the two-item enum, so a user reading the help text looks for a third option that is not there, and a hand-written config setting "broadcast" is rejected by schema validation.

The key is declared twice per plugin — at the config root and under game_limits — and both copies carry the same description.

Two ways to close it:

  1. Drop the sentence from both descriptions. Docs-only, PATCH bump, no behaviour change.
  2. Add broadcast to the enum and implement it. That needs ESPN's broadcast listings in the selection code, and the description already promises a fail-open ("a league ESPN publishes no TV listings for" lets everything through), so the semantics are specified.

Option 1 unless the filter is actually wanted.

Found while documenting nrl-scoreboard (#425); the same text is in the other scoreboards.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions